public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox 0/3] s3-client: fix request signing and update request time on retry
Date: Wed,  7 Oct 2026 14:34:03 +0200	[thread overview]
Message-ID: <20261007123406.429342-1-c.ebner@proxmox.com> (raw)

This patch series fixes 2 issues with the current s3-client
implementation.

In particular:
- Patch 1 fixes an issue with s3-client request signing, encountered
  during development. The canonical request headers and query
  parameters were incorrectly sorted by key+value strings instead
  of key only, which could lead to sorting mismatches with the API
  server, resulting in signature mismatches and therefore rejected
  requests. In particular, this might be encountered if one header
  name is a prefix to another header name.
  Fixed by sorting headers and queries via their respective key only.
- Patches 2+3 fix a not updated request time for requests being
  retried. This could potentially lead to `RequestTimeTooSkewed`
  errors when the time in-between retried requests is very large and
  might explain such errors observed as reported in the community
  forum [0].
  Fixed by setting the current request time and updating the request
  signature each time before sending the request via the client.

[0] https://forum.proxmox.com/threads/186881/


proxmox:

Christian Ebner (3):
  s3-client: fix header and query parameter sorting during aws sign v4
  s3-client: factor out request signing and related header updates
  s3-client: update request time and signature on retries

 proxmox-s3-client/src/aws_sign_v4.rs | 30 ++++++---
 proxmox-s3-client/src/client.rs      | 95 ++++++++++++++--------------
 2 files changed, 67 insertions(+), 58 deletions(-)


Summary over all repositories:
  2 files changed, 67 insertions(+), 58 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-10-07 12:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 12:34 Christian Ebner [this message]
2026-10-07 12:34 ` [PATCH proxmox 1/3] s3-client: fix header and query parameter sorting during aws sign v4 Christian Ebner
2026-10-07 12:34 ` [PATCH proxmox 2/3] s3-client: factor out request signing and related header updates Christian Ebner
2026-10-07 12:34 ` [PATCH proxmox 3/3] s3-client: update request time and signature on retries Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007123406.429342-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal