From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH proxmox-backup 4/5] api: s3: drop unused rpcenv parameter from bucket listing
Date: Wed, 9 Sep 2026 13:12:27 +0200 [thread overview]
Message-ID: <20260909111228.217535-5-e.fastermann@proxmox.com> (raw)
In-Reply-To: <20260909111228.217535-1-e.fastermann@proxmox.com>
The bucket listing never touched the RPC environment, and the API
macro does not require handlers to accept one. Dropping it allows
callers without an RPC environment to use the function directly.
No functional change intended.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
src/api2/config/s3.rs | 5 +----
src/bin/proxmox_backup_manager/s3.rs | 7 ++-----
2 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/src/api2/config/s3.rs b/src/api2/config/s3.rs
index 9cf61d23d..3e6599f53 100644
--- a/src/api2/config/s3.rs
+++ b/src/api2/config/s3.rs
@@ -358,10 +358,7 @@ pub fn delete_s3_client_config(
},
)]
/// List buckets accessible by given s3 client configuration
-pub async fn list_buckets(
- id: String,
- _rpcenv: &mut dyn RpcEnvironment,
-) -> Result<Vec<S3BucketListItem>, Error> {
+pub async fn list_buckets(id: String) -> Result<Vec<S3BucketListItem>, Error> {
let (config, _digest) = pbs_config::s3::config()?;
let config: S3ClientConf = config
.lookup(S3_CFG_TYPE_ID, &id)
diff --git a/src/bin/proxmox_backup_manager/s3.rs b/src/bin/proxmox_backup_manager/s3.rs
index 046b12dd0..b86f5d625 100644
--- a/src/bin/proxmox_backup_manager/s3.rs
+++ b/src/bin/proxmox_backup_manager/s3.rs
@@ -45,11 +45,8 @@ async fn check(
},
)]
/// List buckets accessible by the given S3 client configuration
-async fn list_buckets(
- s3_endpoint_id: String,
- rpcenv: &mut dyn RpcEnvironment,
-) -> Result<Vec<S3BucketListItem>, Error> {
- api2::config::s3::list_buckets(s3_endpoint_id, rpcenv).await
+async fn list_buckets(s3_endpoint_id: String) -> Result<Vec<S3BucketListItem>, Error> {
+ api2::config::s3::list_buckets(s3_endpoint_id).await
}
#[api(
--
2.47.3
next prev parent reply other threads:[~2026-09-09 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-09 11:12 [PATCH proxmox-backup 0/5] report: cover the s3 configuration Erik Fastermann
2026-09-09 11:12 ` [PATCH proxmox-backup 1/5] report: rename mislabeled datastore file group Erik Fastermann
2026-09-09 11:12 ` [PATCH proxmox-backup 2/5] report: do not include remote passwords Erik Fastermann
2026-09-09 11:12 ` [PATCH proxmox-backup 3/5] report: include the s3 endpoint configuration Erik Fastermann
2026-09-09 11:12 ` Erik Fastermann [this message]
2026-09-09 11:12 ` [PATCH proxmox-backup 5/5] report: list the accessible s3 buckets Erik Fastermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260909111228.217535-5-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox