From: Samuel Rufinatscha <s.rufinatscha@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{,-backup} 0/2] fix #7948: acme: disable connection pooling for certificate renewal
Date: Mon, 7 Sep 2026 18:04:32 +0200 [thread overview]
Message-ID: <20260907160434.262678-1-s.rufinatscha@proxmox.com> (raw)
ACME certificate renewal can fail [0] after an order has been finalized
if the CA closes the HTTP/1.1 connection during the polling delay.
Reusing that stale connection then causes the task to fail with:
"TASK ERROR: client error (SendRequest)"
Makes the maximum number of idle connections configurable in the shared
HTTP client and disables connection pooling for ACME requests.
Testing:
The issue was reproduced using Pebble and a proxy which drops a reused
connection after order finalization. The unpatched PBS build failed with
SendRequest, while the patched build opened a new connection for the
subsequent poll and completed certificate issuance successfully.
Notes for the maintainer:
* adds a public field to HttpOptions
* both PBS and PDM require the updated crates
[0] https://bugzilla.proxmox.com/show_bug.cgi?id=7948
proxmox:
Samuel Rufinatscha (1):
fix #7948: acme: disable HTTP connection pooling
proxmox-acme/src/async_client.rs | 1 +
proxmox-http/src/client/simple.rs | 9 +++++++--
proxmox-http/src/http_options.rs | 3 +++
3 files changed, 11 insertions(+), 2 deletions(-)
proxmox-backup:
Samuel Rufinatscha (1):
http: adapt to new pool_max_idle_per_host option
src/api2/node/subscription.rs | 1 +
src/tools/mod.rs | 1 +
2 files changed, 2 insertions(+)
Summary over all repositories:
5 files changed, 13 insertions(+), 2 deletions(-)
--
Generated by git-murpp 0.8.1
next reply other threads:[~2026-09-07 16:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 16:04 Samuel Rufinatscha [this message]
2026-09-07 16:04 ` [PATCH proxmox 1/1] fix #7948: acme: disable HTTP connection pooling Samuel Rufinatscha
2026-09-07 16:04 ` [PATCH proxmox-backup 1/1] http: adapt to new pool_max_idle_per_host option Samuel Rufinatscha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260907160434.262678-1-s.rufinatscha@proxmox.com \
--to=s.rufinatscha@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox