public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup] fix #8003: sync: pull: log skipped chunk reuse for corrupt manifests
Date: Thu,  3 Sep 2026 09:50:51 +0200	[thread overview]
Message-ID: <20260903075051.109065-1-c.ebner@proxmox.com> (raw)

Chunks from a manifest with verify state failed cannot be re-used
since it is not known which chunks are corrupt and/or whether the
index files referenced in the manifest are corrupt. The manifest
is therefore skipped when determining the chunks from the
previous snapshot during sync pull jobs. This was however not logged,
causuing confusion on why a sync job now takes much longer.

Add an additional log line to clarify this.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/server/pull.rs | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/server/pull.rs b/src/server/pull.rs
index 4eb5bcf11..13f4f5b09 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -1273,7 +1273,12 @@ async fn pull_group(
             })?;
 
             match manifest.verify_state()? {
-                Some(verify_state) if verify_state.state == VerifyState::Failed => (),
+                Some(verify_state) if verify_state.state == VerifyState::Failed => {
+                    bail!(
+                        "cannot safely reuse chunks of snapshot {}, verify state failed",
+                        info.backup_dir.backup_time_string(),
+                    );
+                }
                 _ => {
                     for file in manifest.files() {
                         let index: Box<dyn IndexFile> = match file.filename.archive_type() {
-- 
2.47.3





             reply	other threads:[~2026-09-03  7:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  7:50 Christian Ebner [this message]
2026-09-03  7:57 ` [PATCH proxmox-backup] fix #8003: sync: pull: log skipped chunk reuse for corrupt manifests Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260903075051.109065-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal