public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 proxmox-backup 0/3] improve handling of bad S3 chunks during GC
Date: Mon, 13 Jul 2026 15:22:23 +0200	[thread overview]
Message-ID: <20260713132338.170565-1-r.obkircher@proxmox.com> (raw)

Fix an issue where the local path of .i.bad files was computed
incorrectly, and refactor the related code a bit.

I discovered this issue while grepping for "unsafe" to see if it would
make sense to (explicitly) depend on the zerocopy crate for the index
file readers. The removed unsafe statement in the first patch looked
suspicious because it could have been out-of-bounds if to_string_lossy
wasn't guaranteed to be called on an utf8 OsStr.

Robert Obkircher (3):
  datastore: fix local path for .i.bad chunk files during S3 GC
  datastore: check that .i.bad files from S3 actually match that pattern
  datastore: introduce helper function to parse digest from S3ObjectKey

 pbs-datastore/src/chunk_store.rs | 21 +++++++++++------
 pbs-datastore/src/datastore.rs   | 39 ++++++++------------------------
 pbs-datastore/src/s3.rs          | 39 +++++++++++++++++++++++++++++---
 3 files changed, 60 insertions(+), 39 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-07-13 13:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13 13:22 Robert Obkircher [this message]
2026-07-13 13:22 ` [PATCH v1 proxmox-backup 1/3] datastore: fix local path for .i.bad chunk files during S3 GC Robert Obkircher
2026-07-13 13:22 ` [PATCH v1 proxmox-backup 2/3] datastore: check that .i.bad files from S3 actually match that pattern Robert Obkircher
2026-07-13 13:22 ` [PATCH v1 proxmox-backup 3/3] datastore: introduce helper function to parse digest from S3ObjectKey Robert Obkircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260713132338.170565-1-r.obkircher@proxmox.com \
    --to=r.obkircher@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal