From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 0/6] fix #7024: add more information inside backup logs
Date: Mon, 13 Jul 2026 10:15:23 +0200 [thread overview]
Message-ID: <20260713081529.62859-1-s.shaji@proxmox.com> (raw)
This series addresses three issues:
- File number statistics not being shown under change detection summary for data and
legacy mode.
- The pogress logs were not showing the number of processed files.
- There was no verbose option.
Changes since RFC: Thanks to @Christian Ebner
- Patch 2/6: Add more helper functions to PxarArchiverProgressStats
and change their visibility to pub(crate).
- Patch 3/6: Use the new helper functions to show the summary for
both legacy mode and data mode.
- Patch 4/6: Add a preparatory patch for sharing UploadCounters
inside the progress logger callback used in patch 5/6.
- Patch 5/6: Instead of passing PxarArchiverProgressStats around,
add a callback to UploadOptions that accepts UploadCounters and
TimeSpan as parameters. At the UploadOptions creation site, a
closure can then be passed that takes the pxar archiver stats and
logs the output.
- Patch 6/6: Instead of switching the log level based on the verbose
flag, bump the log level to info and gate the output behind the
verbose flag.
- Reword and fix some commit body messages.
Shan Shaji (6):
client: pxar: rename `ReuseStats` struct to PxarArchiverProgressStats
client: pxar: use atomic values in `PxarArchiverProgressStats`
fix #7024: pxar: show archiver summary for legacy and data mode
client: backup_stats: move `uploaded_len` counter to `UploadCounters`
fix #7024: cli: add more information inside the backup progress logs
fix #7024: cli: add option to enable verbose logs
pbs-client/src/backup_stats.rs | 16 +-
pbs-client/src/backup_writer.rs | 43 ++---
pbs-client/src/lib.rs | 2 +-
pbs-client/src/pxar/create.rs | 179 ++++++++++++++----
pbs-client/src/pxar/mod.rs | 3 +-
pbs-client/src/pxar/tools.rs | 9 +-
pbs-client/src/pxar_backup_stream.rs | 13 +-
proxmox-backup-client/src/main.rs | 65 ++++++-
.../src/proxmox_restore_daemon/api.rs | 2 +
pxar-bin/src/main.rs | 2 +
tests/catar.rs | 1 +
11 files changed, 260 insertions(+), 75 deletions(-)
--
2.47.3
next reply other threads:[~2026-07-13 8:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 8:15 Shan Shaji [this message]
2026-07-13 8:15 ` [PATCH proxmox-backup 1/6] client: pxar: rename `ReuseStats` struct to PxarArchiverProgressStats Shan Shaji
2026-07-13 8:15 ` [PATCH proxmox-backup 2/6] client: pxar: use atomic values in `PxarArchiverProgressStats` Shan Shaji
2026-07-13 8:15 ` [PATCH proxmox-backup 3/6] fix #7024: pxar: show archiver summary for legacy and data mode Shan Shaji
2026-07-13 8:15 ` [PATCH proxmox-backup 4/6] client: backup_stats: move `uploaded_len` counter to `UploadCounters` Shan Shaji
2026-07-13 8:15 ` [PATCH proxmox-backup 5/6] fix #7024: cli: add more information inside the backup progress logs Shan Shaji
2026-07-15 12:46 ` Thomas Ellmenreich
2026-07-15 14:06 ` Shan Shaji
2026-07-13 8:15 ` [PATCH proxmox-backup 6/6] fix #7024: cli: add option to enable verbose logs Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260713081529.62859-1-s.shaji@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox