public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [RFC PATCH proxmox-backup] fix #5748: docs: add `catalog.pcat1` format specification
Date: Wed, 17 Jun 2026 17:42:14 +0200	[thread overview]
Message-ID: <20260617154214.509835-1-s.shaji@proxmox.com> (raw)

Earlier proxmox catalog file format specification was not present
inside the docs. fixed it by adding format specification under file
formats.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 Sending this as an RFC because I am not sure whether the names I used make sense.

 I also marked `TABLE_LENGTH`, `ENTRY_COUNT`, `NAME_LENGTH`, `offset_back`, `size`, and
 `mtime` as 64-bit values. However, AFAIU, when these values are written to the file,
 they are encoded as variable length byte sequences. For example, if `NAME_LENGTH` is
 greater than 127, it will be encoded a multiple `u8` values. So, Is it okay to specify
 the type in logical size?

 docs/catalog-format-overview.dot | 45 ++++++++++++++++++++++++++++++++
 docs/file-formats.rst            |  6 +++++
 2 files changed, 51 insertions(+)
 create mode 100644 docs/catalog-format-overview.dot

diff --git a/docs/catalog-format-overview.dot b/docs/catalog-format-overview.dot
new file mode 100644
index 000000000..a9ec64ad3
--- /dev/null
+++ b/docs/catalog-format-overview.dot
@@ -0,0 +1,45 @@
+digraph structs {
+    graph [
+        rankdir = "LR"
+        fontname="Helvetica"
+    ];
+
+    node [
+        fontsize = "16"
+        shape = "record"
+    ];
+
+    catalog [
+        label = "catalog.pcat1"
+    ];
+
+    catalog_payload [
+        label = "<magic> CATALOG_MAGIC: [u8; 8]\l|<blocks> \{DIRECTORY_BLOCK\}*\l|ROOT_DIRECTORY_OFFSET: [u8; 8]\l"
+    ];
+
+    directory_block [
+        label = "<table_length> TABLE_LENGTH: u64\l|<entry_count> ENTRY_COUNT: u64\l|<entries> \{DIRECTORY_ENTRY\}*\l"
+    ];
+
+    directory_entry [
+        label = "<entry_type> ENTRY_TYPE: u8\l|NAME_LENGTH: u64\l|NAME: [u8]\l|<attr> ATTRIBUTE_PAYLOAD\l"
+    ];
+
+    attribute_payload [
+        label = "{{DIRECTORY_PAYLOAD|offset_back: u64}|{FILE_PAYLOAD|size: u64\nmtime: i64}|{OTHER_PAYLOAD|no extra payload}}"
+    ];
+
+    entry_types [
+        label = "'d' directory|'f' file|'l' symlink|'h' hardlink|'b' block device|'c' char device|'p' fifo|'s' socket"
+    ];
+
+    catalog -> catalog_payload:magic;
+
+    catalog_payload:blocks -> directory_block:table_length;
+
+    directory_block:entries -> directory_entry:entry_type;
+
+    directory_entry:attr -> attribute_payload;
+
+    directory_entry:entry_type -> entry_types;
+}
diff --git a/docs/file-formats.rst b/docs/file-formats.rst
index ed3250d11..f67b1b23c 100644
--- a/docs/file-formats.rst
+++ b/docs/file-formats.rst
@@ -1,5 +1,11 @@
 File Formats
 ============
+.. _pcat1-format:
+
+Proxmox Catalog File Format (``.pcat1``)
+----------------------------------------
+
+.. graphviz:: catalog-format-overview.dot
 
 .. _pxar-format:
 
-- 
2.47.3





                 reply	other threads:[~2026-06-17 15:42 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260617154214.509835-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal