public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v4 8/8] chunk store: include filesystem backing path in log output
Date: Thu, 14 May 2026 10:04:57 +0200	[thread overview]
Message-ID: <20260514080458.5677-9-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260514080458.5677-1-c.ebner@proxmox.com>

Allows to easily identify the path being used for syncfs calls.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/chunk_store.rs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs
index 96deb840d..5bde30df1 100644
--- a/pbs-datastore/src/chunk_store.rs
+++ b/pbs-datastore/src/chunk_store.rs
@@ -995,9 +995,10 @@ impl ChunkStore {
             return Ok(());
         }
 
-        let file = std::fs::File::open(self.base_path())?;
+        let base_path = self.base_path();
+        let file = std::fs::File::open(&base_path)?;
         let fd = file.as_raw_fd();
-        info!("syncing filesystem");
+        info!("syncing filesystem for backing path '{base_path:?}'");
         if unsafe { libc::syncfs(fd) } < 0 {
             bail!("error during syncfs: {}", std::io::Error::last_os_error());
         }
-- 
2.47.3





  parent reply	other threads:[~2026-05-14  8:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-14  8:04 [PATCH proxmox{,-backup} v4 0/8] fix sync level updates for chunk store Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox v4 1/8] pbs-api-types: derive FromStr for DatastoreTuning parsing Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 2/8] datastore: GC: avoid double parsing of datastore tuning options Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 3/8] pbs-config/datastore: add common helper for parsing " Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 4/8] datastore: restrict chunk store mutex scope to crate only Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 5/8] datastore: avoid useless double borrowing of datastore Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 6/8] datastore: move try_ensure_sync_level() implementation to chunk store Christian Ebner
2026-05-14  8:04 ` [PATCH proxmox-backup v4 7/8] datastore: fix sync level update propagation " Christian Ebner
2026-05-14  8:04 ` Christian Ebner [this message]
2026-05-15 10:01 ` [PATCH proxmox{,-backup} v4 0/8] fix sync level updates for " Robert Obkircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260514080458.5677-9-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal