public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox 1/3] s3-client: add flag to opt-in for using node proxy for connections
Date: Mon, 11 May 2026 17:19:22 +0200	[thread overview]
Message-ID: <20260511151924.901315-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260511151924.901315-1-c.ebner@proxmox.com>

So users can avoid using the node proxy config as introduced by
commit fbf8d1b25 ("fix #6716: pass node http proxy config to s3
backend").

Default to false, as this is the originally intended behaviour.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-s3-client/src/api_types.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs
index 217bee11..e860a8d9 100644
--- a/proxmox-s3-client/src/api_types.rs
+++ b/proxmox-s3-client/src/api_types.rs
@@ -145,6 +145,11 @@ serde_plain::derive_fromstr_from_deserialize!(ProviderQuirks);
             type: HumanByte,
             optional: true,
         },
+        "use-node-proxy": {
+            type: bool,
+            optional: true,
+            default: false,
+        },
     },
 )]
 #[derive(Serialize, Deserialize, Updater, Clone, PartialEq)]
@@ -185,6 +190,9 @@ pub struct S3ClientConfig {
     /// Upload burst
     #[serde(skip_serializing_if = "Option::is_none")]
     pub burst_out: Option<HumanByte>,
+    /// Use node proxy for client connections
+    #[serde(skip_serializing_if = "Option::is_none")]
+    pub use_node_proxy: Option<bool>,
 }
 
 impl S3ClientConfig {
-- 
2.47.3





  reply	other threads:[~2026-05-11 15:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 15:19 [PATCH proxmox{,-backup} 0/3] add flag to opt-in using node proxy config for s3 connections Christian Ebner
2026-05-11 15:19 ` Christian Ebner [this message]
2026-05-11 15:19 ` [PATCH proxmox-backup 2/3] api: config: allow editing the use-node-config flag for s3 endpoints Christian Ebner
2026-05-11 15:19 ` [PATCH proxmox-backup 3/3] ui: add opt-in flag for using the node proxy config for s3 connections Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511151924.901315-2-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal