public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{,-backup} v2 0/3] fix #6373: HTTP level keepalive for http2 backup reader/writer connection
Date: Mon, 11 May 2026 15:46:07 +0200	[thread overview]
Message-ID: <20260511134610.675164-1-c.ebner@proxmox.com> (raw)

Patches implement a HTTP level keepalive mechanism to avoid of active
but idle http2 connections established by the backup reader or writer
being dropped by reverse proxies.
Regular heartbeat requests are send to the Proxmox Backup Server, the
frequency based on a given timeout. Heartbeat traffic is only send if
no other requests have been send during the timeout period. The
timeout given in seconds is read from the respective environment
variable, PBS_READER_HEARTBEAT_TIMEOUT for readers and
PBS_WRITER_HEARTBEAT_TIMEOUT for writers. If not set, no heartbeat
traffic is being send.

Since each HTTP request is being logged to the task log for http2
connections, implement a filtering logic allowing to exclude these
request logs to avoid log flodding.

Example configurations for testing can be found on the individual
patch fixing the issue.

Changes since RFC version (thanks @Fabian for comments and suggestions):
- Implement heartbeat traffic also for backup writer, not just reader
- Refactor and combine common logic for both variants
- Fix request method to be get() instead of download()
- Threat env variable parsing errors as errors instead of ignoring them

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=6373


proxmox:

Christian Ebner (1):
  rest-server: add request logfilter by method and path in h2 service

 proxmox-rest-server/src/h2service.rs | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)


proxmox-backup:

Christian Ebner (2):
  api: add heartbeat endpoint for backup reader/writer http/2 clients
  fix #6373: HTTP level client heartbeat for proxy connection keepalive

 pbs-client/src/backup_reader.rs |  67 ++++++++++++++--
 pbs-client/src/backup_writer.rs | 131 +++++++++++++++++++++++++++++---
 pbs-client/src/lib.rs           |  25 ++++++
 src/api2/backup/mod.rs          |  13 +++-
 src/api2/helpers.rs             |  14 +++-
 src/api2/reader/mod.rs          |  13 +++-
 6 files changed, 238 insertions(+), 25 deletions(-)


Summary over all repositories:
  7 files changed, 254 insertions(+), 27 deletions(-)

-- 
Generated by murpp 0.11.0




             reply	other threads:[~2026-05-11 13:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 13:46 Christian Ebner [this message]
2026-05-11 13:46 ` [PATCH proxmox v2 1/3] rest-server: add request logfilter by method and path in h2 service Christian Ebner
2026-05-11 13:46 ` [PATCH proxmox-backup v2 2/3] api: add heartbeat endpoint for backup reader/writer http/2 clients Christian Ebner
2026-05-11 13:46 ` [PATCH proxmox-backup v2 3/3] fix #6373: HTTP level client heartbeat for proxy connection keepalive Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511134610.675164-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal