From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com
Subject: [PATCH manager 2/2] ui: add location to datacenter and node options
Date: Fri, 8 May 2026 10:40:16 +0200 [thread overview]
Message-ID: <20260508084038.1405206-6-d.csapak@proxmox.com> (raw)
In-Reply-To: <20260508084038.1405206-1-d.csapak@proxmox.com>
uses the renderer and edit window from widget toolkit.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/OptionView.js | 9 +++++++++
www/manager6/node/NodeOptionsView.js | 16 ++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js
index 7c8d3792..da9d216b 100644
--- a/www/manager6/dc/OptionView.js
+++ b/www/manager6/dc/OptionView.js
@@ -568,6 +568,15 @@ Ext.define('PVE.dc.OptionView', {
onlineHelp: 'gui_consent_banner',
});
+ me.rows.location = {
+ required: true,
+ header: gettext('Location'),
+ renderer: Proxmox.Utils.renderLocation,
+ editor: {
+ xtype: 'pmxLocationEditWindow',
+ },
+ };
+
me.selModel = Ext.create('Ext.selection.RowModel', {});
Ext.apply(me, {
diff --git a/www/manager6/node/NodeOptionsView.js b/www/manager6/node/NodeOptionsView.js
index 88170531..5e9ce791 100644
--- a/www/manager6/node/NodeOptionsView.js
+++ b/www/manager6/node/NodeOptionsView.js
@@ -41,6 +41,22 @@ Ext.define('Proxmox.node.NodeOptionsView', {
},
],
+ rows: {
+ location: {
+ required: true,
+ header: gettext('Location'),
+ renderer: function (value) {
+ if (!value) {
+ return gettext('from Datacenter options');
+ }
+ return Proxmox.Utils.renderLocation(value);
+ },
+ editor: {
+ xtype: 'pmxLocationEditWindow',
+ },
+ },
+ },
+
gridRows: [
{
xtype: 'integer',
--
2.47.3
next prev parent reply other threads:[~2026-05-08 8:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 8:40 [PATCH cluster/manager/proxmox{,-backup}/widget-toolkit 0/8] add location property to node/datacenter config for PVE/PBS Dominik Csapak
2026-05-08 8:40 ` [PATCH cluster 1/1] datacenter config: add location property Dominik Csapak
2026-05-08 8:40 ` [PATCH widget-toolkit 1/2] add window and renderer for locations Dominik Csapak
2026-05-08 8:40 ` [RFC PATCH widget-toolkit 2/2] utils: render location: add a link to that location on openstreetmap Dominik Csapak
2026-05-08 8:40 ` [PATCH manager 1/2] node config: add location property Dominik Csapak
2026-05-08 8:40 ` Dominik Csapak [this message]
2026-05-08 8:40 ` [PATCH proxmox 1/1] pbs-api-types: " Dominik Csapak
2026-05-08 8:40 ` [PATCH proxmox-backup 1/2] api: node: " Dominik Csapak
2026-05-08 8:40 ` [PATCH proxmox-backup 2/2] ui: node options: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508084038.1405206-6-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox