From: Erik Fastermann <e.fastermann@proxmox.com>
To: pbs-devel@lists.proxmox.com
Cc: Erik Fastermann <e.fastermann@proxmox.com>
Subject: [PATCH proxmox-backup v3 4/6] ui: datastore: disable remove action for namespaces
Date: Thu, 7 May 2026 10:57:25 +0200 [thread overview]
Message-ID: <20260507085728.11852-5-e.fastermann@proxmox.com> (raw)
In-Reply-To: <20260507085728.11852-1-e.fastermann@proxmox.com>
Since the namespace entry does not show a remove button,
also disable the action itself and hide the tooltip.
Signed-off-by: Erik Fastermann <e.fastermann@proxmox.com>
---
changes since v2:
* explain the why in the commit message
www/datastore/Content.js | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/datastore/Content.js b/www/datastore/Content.js
index 42a48a742..659f5c2eb 100644
--- a/www/datastore/Content.js
+++ b/www/datastore/Content.js
@@ -1212,7 +1212,13 @@ Ext.define('PBS.DataStoreContent', {
data.ty === 'dir'
? 'fa critical fa-trash-o'
: 'pmx-hidden',
- isActionDisabled: (v, r, c, i, { data }) => false,
+ isActionDisabled: (v, r, c, i, { data }) => {
+ const enabled =
+ (data.ty === 'ns' && !data.isRootNS && data.ns === undefined) ||
+ data.ty === 'group' ||
+ data.ty === 'dir';
+ return !enabled;
+ },
},
{
handler: 'downloadFile',
--
2.47.3
next prev parent reply other threads:[~2026-05-07 8:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 8:57 [PATCH proxmox-backup v3 0/6] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 1/6] ui: datastore: update code formatting with biome Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 2/6] fix #6691: allow search by comment in datastore content Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 3/6] ui: datastore: case-insensitive search on all content fields Erik Fastermann
2026-05-07 8:57 ` Erik Fastermann [this message]
2026-05-07 8:57 ` [PATCH proxmox-backup v3 5/6] ui: datastore: disable browse action for root ns Erik Fastermann
2026-05-07 8:57 ` [PATCH proxmox-backup v3 6/6] ui: datastore: fix content search empty tree Erik Fastermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260507085728.11852-5-e.fastermann@proxmox.com \
--to=e.fastermann@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox