public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH widget-toolkit] confirm remove dialog: improve layout for larger fields/components
Date: Wed, 29 Apr 2026 12:12:03 +0200	[thread overview]
Message-ID: <20260429101328.1651618-1-d.csapak@proxmox.com> (raw)

If there are larger fields e.g. in the additionalItems property, the
current layout configuration leads to cut-off text and fields.

To fix this, apply 'flex: 1' to the overall body and actual content
component (so they adapt their size) and use 'align: stretch' for the
content vbox (so the elements adapt to the size of the other content
elements).

with that, these larger elements (e.g. a hint box) will either shrink,
or wrap it's text.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/window/ConfirmRemoveDialog.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/window/ConfirmRemoveDialog.js b/src/window/ConfirmRemoveDialog.js
index 94f1e84..5f76e47 100644
--- a/src/window/ConfirmRemoveDialog.js
+++ b/src/window/ConfirmRemoveDialog.js
@@ -133,6 +133,7 @@ Ext.define('Proxmox.window.ConfirmRemoveDialog', {
         }
 
         let body = {
+            flex: 1,
             xtype: 'container',
             layout: 'hbox',
             items: [
@@ -149,8 +150,12 @@ Ext.define('Proxmox.window.ConfirmRemoveDialog', {
         }
 
         let content = {
+            flex: 1,
             xtype: 'container',
-            layout: 'vbox',
+            layout: {
+                type: 'vbox',
+                align: 'stretch',
+            },
             items: [
                 {
                     xtype: 'component',
-- 
2.47.3





             reply	other threads:[~2026-04-29 10:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 10:12 Dominik Csapak [this message]
2026-04-29 11:03 ` applied: [PATCH widget-toolkit] confirm remove dialog: improve layout for larger fields/components Thomas Lamprecht
2026-04-29 11:04 ` Samuel Rufinatscha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260429101328.1651618-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal