From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 2/2] ui: datastore: expose gc-on-unmount setting
Date: Fri, 17 Apr 2026 13:27:55 +0200 [thread overview]
Message-ID: <20260417112755.136134-3-h.laimer@proxmox.com> (raw)
In-Reply-To: <20260417112755.136134-1-h.laimer@proxmox.com>
Shows the gc-on-unmount option in the datastore options and allows
editing for removable datastores.
Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
www/datastore/OptionView.js | 23 +++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 160edd44..2b35355a 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -104,6 +104,7 @@ Ext.define('PBS.Datastore.Options', {
let record = listStore.findRecord('store', me.datastore, 0, false, true, true);
return {
s3Visible: record?.get('backend-type') === 's3' ? undefined : false,
+ removableVisible: record?.get('mount-status') !== 'nonremovable' ? undefined : false,
};
},
@@ -226,6 +227,28 @@ Ext.define('PBS.Datastore.Options', {
},
},
},
+ 'gc-on-unmount': {
+ required: true,
+ header: gettext('GC on Unmount'),
+ defaultValue: false,
+ renderer: Proxmox.Utils.format_boolean,
+ cbind: {
+ visible: '{removableVisible}',
+ },
+ editor: {
+ xtype: 'proxmoxWindowEdit',
+ title: gettext('GC on Unmount'),
+ width: 350,
+ items: {
+ xtype: 'proxmoxcheckbox',
+ name: 'gc-on-unmount',
+ boxLabel: gettext('Run garbage collection before unmounting'),
+ defaultValue: false,
+ deleteDefaultValue: true,
+ deleteEmpty: true,
+ },
+ },
+ },
'maintenance-mode': {
required: true,
header: gettext('Maintenance mode'),
--
2.47.3
next prev parent reply other threads:[~2026-04-17 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-17 11:27 [PATCH proxmox-backup 0/2] fixes #7465: add gc-on-unmount flag Hannes Laimer
2026-04-17 11:27 ` [PATCH proxmox-backup 1/2] api: datastore: add option to run garbage collection before unmount Hannes Laimer
2026-04-17 14:35 ` Christian Ebner
2026-04-17 11:27 ` Hannes Laimer [this message]
2026-04-17 14:56 ` [PATCH proxmox-backup 0/2] fixes #7465: add gc-on-unmount flag Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260417112755.136134-3-h.laimer@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox