[PATCH proxmox-backup v8 12/17] datastore: add thresholds notification callback on datastore lookup

[Christian Ebner <c.ebner@proxmox.com>]

Pass in the callback to be executed when a datastore threshold value
exceeds its set limit. This callback is then callable by the s3
client request counters implementation, currently the only component
defining thresholds.

When a threshold is exceeded, the notification is generated by the
callback and queued for being send.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
---
changes since version 7:
- no changes

 pbs-datastore/src/datastore.rs       | 36 ++++++++++++++++++++++++----
 pbs-datastore/src/snapshot_reader.rs |  1 +
 src/tools/mod.rs                     |  6 ++++-
 3 files changed, 38 insertions(+), 5 deletions(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index 2d63f7527..66cd30cea 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -202,14 +202,25 @@ impl DataStoreImpl {
     }
 }
 
+pub type ThresholdsExceededCallback = fn(&str, &str, u64, u64) -> Result<(), Error>;
+
 pub struct DataStoreLookup<'a> {
     name: &'a str,
     operation: Operation,
+    thresholds_exceeded_callback: Option<ThresholdsExceededCallback>,
 }
 
 impl<'a> DataStoreLookup<'a> {
-    pub fn with(name: &'a str, operation: Operation) -> Self {
-        Self { name, operation }
+    pub fn with(
+        name: &'a str,
+        operation: Operation,
+        thresholds_exceeded_callback: Option<ThresholdsExceededCallback>,
+    ) -> Self {
+        Self {
+            name,
+            operation,
+            thresholds_exceeded_callback,
+        }
     }
 }
 
@@ -556,7 +567,12 @@ impl DataStore {
             )?)
         };
 
-        let datastore = DataStore::with_store_and_config(chunk_store, config, gen_num)?;
+        let datastore = DataStore::with_store_and_config(
+            chunk_store,
+            config,
+            gen_num,
+            lookup.thresholds_exceeded_callback,
+        )?;
 
         let datastore = Arc::new(datastore);
         datastore_cache.insert(lookup.name.to_string(), datastore.clone());
@@ -591,7 +607,7 @@ impl DataStore {
         {
             // the datastore drop handler does the checking if tasks are running and clears the
             // cache entry, so we just have to trigger it here
-            let lookup = DataStoreLookup::with(name, Operation::Lookup);
+            let lookup = DataStoreLookup::with(name, Operation::Lookup, None);
             let _ = DataStore::lookup_datastore(lookup);
         }
 
@@ -645,6 +661,7 @@ impl DataStore {
             Arc::new(chunk_store),
             config,
             None,
+            None,
         )?);
 
         if let Some(operation) = operation {
@@ -658,6 +675,7 @@ impl DataStore {
         chunk_store: Arc<ChunkStore>,
         config: DataStoreConfig,
         generation: Option<usize>,
+        thresholds_exceeded_callback: Option<ThresholdsExceededCallback>,
     ) -> Result<DataStoreImpl, Error> {
         let mut gc_status_path = chunk_store.base_path();
         gc_status_path.push(".gc-status");
@@ -710,6 +728,16 @@ impl DataStore {
                 let mut request_counters = Self::request_counters(&config, &backend_config)?;
 
                 Self::update_notification_thresholds(&mut request_counters, &config)?;
+                request_counters.set_thresholds_exceeded_callback(
+                    config.name,
+                    Box::new(move |label, counter_id, threshold, value| {
+                        thresholds_exceeded_callback.map(|cb| {
+                            if let Err(err) = cb(label, counter_id, threshold, value) {
+                                log::error!("failed to send notification: {err:?}");
+                            }
+                        });
+                    }),
+                );
 
                 (Some(cache), Some(Arc::new(request_counters)))
             } else {
diff --git a/pbs-datastore/src/snapshot_reader.rs b/pbs-datastore/src/snapshot_reader.rs
index d522a02d7..7f7625f91 100644
--- a/pbs-datastore/src/snapshot_reader.rs
+++ b/pbs-datastore/src/snapshot_reader.rs
@@ -166,6 +166,7 @@ impl<F: Fn(&[u8; 32]) -> bool> Iterator for SnapshotChunkIterator<'_, F> {
                         let lookup = DataStoreLookup::with(
                             self.snapshot_reader.datastore_name(),
                             Operation::Read,
+                            None,
                         );
                         let datastore = DataStore::lookup_datastore(lookup)?;
                         let order =
diff --git a/src/tools/mod.rs b/src/tools/mod.rs
index a82aaf136..5b6a4c293 100644
--- a/src/tools/mod.rs
+++ b/src/tools/mod.rs
@@ -192,5 +192,9 @@ pub(crate) fn backup_info_to_snapshot_list_item(
 /// Lookup the datastore by name with given operation.
 #[inline(always)]
 pub fn lookup_with<'a>(name: &'a str, operation: Operation) -> DataStoreLookup<'a> {
-    DataStoreLookup::with(name, operation)
+    DataStoreLookup::with(
+        name,
+        operation,
+        Some(crate::server::notifications::send_datastore_threshold_exceeded),
+    )
 }
-- 
2.47.3