public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup 1/5] tools: add helper to run fstrim command on path or mountpoint
Date: Thu, 19 Mar 2026 15:36:45 +0100	[thread overview]
Message-ID: <20260319143649.681937-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260319143649.681937-1-c.ebner@proxmox.com>

Runs the fstrim on the filesystem mounted at given mountpoint or path
on the filesystem, allowing to discard unused blocks on the backing
disk. By invoking with `verbose` flag enabled, statistics are
gathered in the output to show on result. Setting `quiet-unsupported`
allows to run the command without error also on filesystems without
support [0].

With the intention to run this as scheduled job on a datastore's
backing filesystem.

[0] https://www.man7.org/linux/man-pages/man8/fstrim.8.html

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/tools/disks/mod.rs | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/src/tools/disks/mod.rs b/src/tools/disks/mod.rs
index a86cbdf79..a5cb091a7 100644
--- a/src/tools/disks/mod.rs
+++ b/src/tools/disks/mod.rs
@@ -1392,3 +1392,13 @@ pub fn unmount_by_mountpoint(path: &Path) -> Result<(), Error> {
     proxmox_sys::command::run_command(command, None)?;
     Ok(())
 }
+
+/// Run fstrim on mounted filesystem backing given path.
+pub fn fstrim(path: &Path) -> Result<String, Error> {
+    let mut command = std::process::Command::new("fstrim");
+    command.arg(path);
+    command.arg("--verbose");
+    command.arg("--quiet-unsupported");
+
+    proxmox_sys::command::run_command(command, Some(|exit_code| exit_code == 0))
+}
-- 
2.47.3





  parent reply	other threads:[~2026-03-19 14:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-19 14:36 [RFC proxmox{,-backup} 0/6] add scheduled fstrim job for datastore's backing filesystems Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox 1/1] pbs-api-types: define fstrim schedule on datastore config Christian Ebner
2026-03-19 14:36 ` Christian Ebner [this message]
2026-03-19 14:36 ` [PATCH proxmox-backup 2/5] api: config: expose fstrim schedule for datastores Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 3/5] bin: proxy: periodically schedule fstrim on datastore's filesystems Christian Ebner
2026-03-19 15:02   ` Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 4/5] ui: expose per-datastore fstrim job schedule Christian Ebner
2026-03-19 14:36 ` [PATCH proxmox-backup 5/5] api: set default fstrim schedule on datastore create Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260319143649.681937-3-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal