[PATCH proxmox-backup v2 0/3] fix #7400: improve handling of corrupted job statefiles

["Michael Köppl" <m.koeppl@proxmox.com>]

This patch series fixes a problem where an empty or corrupted job state
file (due to I/O error, abrupt shutdown, ...) would cause API endpoints
for listing jobs to return an error, breaking the web UI for users
because they could not view any of their configured jobs of that type.
It would also cause proxmox-backup-proxy to indefinitely skip the jobs
until a user manually triggered it to rewrite the statefile.

1/3 is a preparatory patch that centralizes job statefile loading
in compute_schedule_status instead of having every handler function
open the statefile, handle potential errors and then passing the
JobState to compute_schedule_status.

2/3 fixes the API layer by catching the load error, logging an error
message, and returning a default JobScheduleStatus. This ensure the API
returns the job list, showing the affected job without its last run
status.

3/3 updates the scheduler loop inside the proxy to match the behavior of
a a newly created job, triggering the job at its next internal (which
then rewrites the statefile).

changes since v1:
- added preparatory patch 1/3, centralizing the statefile loading before
  adapting the handling of the error case in that centralized place
  (compute_schedule_status). Thanks, Christian for the suggestion!
- adapted the error message if job statefile loading fails to make clear
  that the default status will be returned as a fallback


proxmox-backup:

Michael Köppl (3):
  api: move statefile loading into compute_schedule_status
  fix #7400: api: gracefully handle corrupted job statefiles
  fix #7400: proxy: self-heal corrupted job statefiles

 src/api2/admin/datastore.rs     | 13 +++----------
 src/api2/admin/prune.rs         |  9 +++------
 src/api2/admin/sync.rs          |  9 +++------
 src/api2/admin/verify.rs        |  9 +++------
 src/api2/tape/backup.rs         |  9 +++------
 src/bin/proxmox-backup-proxy.rs |  2 +-
 src/server/jobstate.rs          | 17 +++++++++++++++--
 7 files changed, 31 insertions(+), 37 deletions(-)


Summary over all repositories:
  7 files changed, 31 insertions(+), 37 deletions(-)

-- 
Generated by murpp 0.10.0