public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v2 1/1] fix #7329: api: avoid overwriting existing IPv6 config method
Date: Mon, 16 Mar 2026 16:21:01 +0100	[thread overview]
Message-ID: <20260316152101.207406-3-s.shaji@proxmox.com> (raw)
In-Reply-To: <20260316152101.207406-1-s.shaji@proxmox.com>

If the inet6 address family's cidr6/gatway6 values are not present, the
interface.method6 values is mutated with `NetworkConfigMethod::Manual`
even if the interface.method6 already has a value. For example, if
the config method is `auto` then it gets replaced by `Manual` config
method.

Later, when writing the config file to the interfaces.new file if the
config method is manual and if there are no IPv6 specific attributes
present, then the inet6 stanza gets skipped.

In order to fix the issue update the condition to only set the config
method to `::Manual` if there is no value present inside the `method6`
property of the interface object.

Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7329
Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---

 **note**: This is a new patch. 
 
 src/api2/node/network.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/api2/node/network.rs b/src/api2/node/network.rs
index 4ee0231d..d0a04e59 100644
--- a/src/api2/node/network.rs
+++ b/src/api2/node/network.rs
@@ -782,7 +782,7 @@ pub fn update_interface(
 
     if interface.cidr6.is_some() || interface.gateway6.is_some() {
         interface.method6 = Some(NetworkConfigMethod::Static);
-    } else {
+    } else if interface.method6.is_none() {
         interface.method6 = Some(NetworkConfigMethod::Manual);
     }
 
-- 
2.47.3





  parent reply	other threads:[~2026-03-16 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 15:20 [PATCH proxmox{,-backup} v2 0/2] fix #7329: network: unkwown iface option error Shan Shaji
2026-03-16 15:21 ` [PATCH proxmox v2 1/1] fix #7329: proxmox-network-api: add missing `Auto` network config method Shan Shaji
2026-03-16 15:21 ` Shan Shaji [this message]
2026-03-17 14:15 ` [PATCH proxmox{,-backup} v2 0/2] fix #7329: network: unkwown iface option error Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316152101.207406-3-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal