public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Shan Shaji <s.shaji@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox{,-backup} v2 0/2] fix #7329: network: unkwown iface option error
Date: Mon, 16 Mar 2026 16:20:59 +0100	[thread overview]
Message-ID: <20260316152101.207406-1-s.shaji@proxmox.com> (raw)

Using `inet6 auto` resulted in an error message in the web GUI. To fix
the issue, I added the `Auto` config method variant to the `NetworkConfigMethod` enum.
This fixed the error in the web GUI, but when editing the interface through the UI,
the `inet6 (auto)` family was still being removed.

For example, if I updated only the comment for the interface, the `auto` method was dropped.

This happened because, when editing the interface without providing
`cidr6` or `gateway6` values, the config method was being replaced
with `Manual` regardless of the current `inet6` method from the existing config.

Later, when writing the config to interfaces.new file if the config method was
`Manual` and there were no values present inside the `inet6` block, then the
entire stanza was removed.

To fix this, the `inet6` config method is now set to `Manual` only if the
interface method6 prop does not already have a value.

changes since v1: Thanks @chris
- added `fixes` trailer.
- fixed typo s/Inorder/In order
- api: fixed inet6 stanza getting dropped. 

#### Testing
- added a new bridge interface from the web UI.
- manually added inet6 (auto) address family to /etc/network/interfaces file for the
  bridge interface. 
- now from web ui, added a comment for the same interface. 
- verified if the block is getting removed. The comment was added and the block
  not getting removed. 
- Now updated the vmbr0 IPv4/CIDR value.
- verified if the method changed from manual to static.
- updated the vmbr0 IPv6/CIDR value.
- verified if the method changed from auto to static. 

proxmox:

Shan Shaji (1):
  fix #7329: proxmox-network-api: add missing `Auto` network config
    method

 proxmox-network-api/src/api_types.rs     |  2 ++
 proxmox-network-api/src/config/mod.rs    |  1 +
 proxmox-network-api/src/config/parser.rs | 43 ++++++++++++++++++++++++
 3 files changed, 46 insertions(+)


proxmox-backup:

Shan Shaji (1):
  fix #7329: api: avoid overwriting existing IPv6 config method

 src/api2/node/network.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


Summary over all repositories:
  4 files changed, 47 insertions(+), 1 deletions(-)

-- 
Generated by git-murpp 0.8.1




             reply	other threads:[~2026-03-16 15:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-16 15:20 Shan Shaji [this message]
2026-03-16 15:21 ` [PATCH proxmox v2 1/1] fix #7329: proxmox-network-api: add missing `Auto` network config method Shan Shaji
2026-03-16 15:21 ` [PATCH proxmox-backup v2 1/1] fix #7329: api: avoid overwriting existing IPv6 " Shan Shaji
2026-03-17 14:15 ` [PATCH proxmox{,-backup} v2 0/2] fix #7329: network: unkwown iface option error Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316152101.207406-1-s.shaji@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal