public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v3 4/6] tools: drop unused from_property_string() helper
Date: Thu, 12 Mar 2026 12:42:06 +0100	[thread overview]
Message-ID: <20260312114208.514373-7-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260312114208.514373-1-c.ebner@proxmox.com>

Since the NodeConfig has been moved and there are no further call
sides it is safe to drop.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 src/tools/config.rs | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/src/tools/config.rs b/src/tools/config.rs
index 2c1078676..413ff3f9e 100644
--- a/src/tools/config.rs
+++ b/src/tools/config.rs
@@ -113,17 +113,6 @@ fn parse_value(value: &str, schema: Option<&'static Schema>) -> Result<Value, Er
     }
 }
 
-/// Parse a string as a property string into a deserializable type. This is just a short wrapper
-/// around deserializing the s
-pub fn from_property_string<T>(input: &str, schema: &'static Schema) -> Result<T, Error>
-where
-    T: for<'de> Deserialize<'de>,
-{
-    Ok(serde_json::from_value(
-        schema.parse_property_string(input)?,
-    )?)
-}
-
 /// Serialize a data structure using a 'key: value' config file format.
 pub fn to_bytes<T: Serialize>(value: &T, schema: &'static Schema) -> Result<Vec<u8>, Error> {
     value_to_bytes(&serde_json::to_value(value)?, schema)
-- 
2.47.3





  parent reply	other threads:[~2026-03-12 11:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-12 11:42 [PATCH proxmox{,-backup} v3 0/8] fix #6716: Add support for http proxy configuration for S3 endpoints Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox v3 1/2] http: move http proxy schema from PBS to crate's api types Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox v3 2/2] pbs-api-types: move over NodeConfig and related api type from PBS Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox-backup v3 1/6] pbs-config: use http proxy schema moved to proxmox-http crate Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox-backup v3 2/6] config: inline NodeConfig::validate() to its only call side Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox-backup v3 3/6] config: use moved NodeConfig definitions in pbs-api-types Christian Ebner
2026-03-12 11:42 ` Christian Ebner [this message]
2026-03-12 11:42 ` [PATCH proxmox-backup v3 5/6] config: move node config into pbs-config, including helper tools Christian Ebner
2026-03-12 11:42 ` [PATCH proxmox-backup v3 6/6] fix #6716: pass node http proxy config to s3 backend Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260312114208.514373-7-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal