public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox-backup v4 18/22] ui: add notification thresholds edit window
Date: Tue,  3 Mar 2026 16:23:13 +0100	[thread overview]
Message-ID: <20260303152317.934256-32-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260303152317.934256-1-c.ebner@proxmox.com>

Allows setting the notification thresholds via the datastore options.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 www/Makefile                         |   1 +
 www/datastore/OptionView.js          |   9 +++
 www/window/NotificationThresholds.js | 113 +++++++++++++++++++++++++++
 3 files changed, 123 insertions(+)
 create mode 100644 www/window/NotificationThresholds.js

diff --git a/www/Makefile b/www/Makefile
index 9ebf0445f..5002bae90 100644
--- a/www/Makefile
+++ b/www/Makefile
@@ -81,6 +81,7 @@ JSSRC=							\
 	window/NamespaceEdit.js				\
 	window/MaintenanceOptions.js			\
 	window/NotesEdit.js				\
+	window/NotificationThresholds.js		\
 	window/RemoteEdit.js				\
 	window/TrafficControlEdit.js			\
 	window/NotifyOptions.js				\
diff --git a/www/datastore/OptionView.js b/www/datastore/OptionView.js
index 7854e64d7..f800c167f 100644
--- a/www/datastore/OptionView.js
+++ b/www/datastore/OptionView.js
@@ -334,5 +334,14 @@ Ext.define('PBS.Datastore.Options', {
                 },
             },
         },
+        'notification-thresholds': {
+            required: true,
+            header: gettext('Notification Thresholds'),
+            renderer: (v) =>
+                PBS.Utils.render_notification_thresholds(PBS.Utils.parsePropertyString(v)),
+            editor: {
+                xtype: 'pbsNotificationThresholdsEdit',
+            },
+        },
     },
 });
diff --git a/www/window/NotificationThresholds.js b/www/window/NotificationThresholds.js
new file mode 100644
index 000000000..19b3598e6
--- /dev/null
+++ b/www/window/NotificationThresholds.js
@@ -0,0 +1,113 @@
+Ext.define('PBS.window.NotificationThresholds', {
+    extend: 'Proxmox.window.Edit',
+    xtype: 'pbsNotificationThresholdsEdit',
+    mixins: ['Proxmox.Mixin.CBind'],
+
+    subject: gettext('Notification Thresholds'),
+
+    width: 500,
+    fieldDefaults: {
+        labelWidth: 120,
+    },
+
+    items: {
+        xtype: 'inputpanel',
+        onGetValues: function (values) {
+            if (!Ext.isArray(values.delete ?? [])) {
+                values.delete = [values.delete];
+            }
+            for (const k of values.delete ?? []) {
+                delete values[k];
+            }
+            delete values.delete;
+            let notificationThresholds = PBS.Utils.printPropertyString(values);
+            if (!notificationThresholds) {
+                return { delete: 'notification-thresholds' };
+            }
+            return { 'notification-thresholds': notificationThresholds };
+        },
+        onSetValues: function (values) {
+            if (values['notification-thresholds']) {
+                return PBS.Utils.parsePropertyString(values['notification-thresholds']);
+            }
+        },
+        items: [
+            {
+                xtype: 'box',
+                html: `<b>${gettext('S3 requests count:')}</b>`,
+                padding: '10 0 5 0',
+            },
+            {
+                xtype: 'proxmoxintegerfield',
+                name: 's3-get',
+                fieldLabel: gettext('GET'),
+                emptyText: gettext('none'),
+                fieldStyle: 'text-align: right',
+                minValue: 0,
+                deleteEmpty: true,
+            },
+            {
+                xtype: 'proxmoxintegerfield',
+                name: 's3-put',
+                fieldLabel: gettext('PUT'),
+                emptyText: gettext('none'),
+                fieldStyle: 'text-align: right',
+                minValue: 0,
+                deleteEmpty: true,
+            },
+            {
+                xtype: 'proxmoxintegerfield',
+                name: 's3-post',
+                fieldLabel: gettext('POST'),
+                emptyText: gettext('none'),
+                fieldStyle: 'text-align: right',
+                minValue: 0,
+                deleteEmpty: true,
+            },
+            {
+                xtype: 'proxmoxintegerfield',
+                name: 's3-head',
+                fieldLabel: gettext('HEAD'),
+                emptyText: gettext('none'),
+                fieldStyle: 'text-align: right',
+                minValue: 0,
+                deleteEmpty: true,
+            },
+            {
+                xtype: 'proxmoxintegerfield',
+                name: 's3-delete',
+                fieldLabel: gettext('DELETE'),
+                emptyText: gettext('none'),
+                fieldStyle: 'text-align: right',
+                minValue: 0,
+                deleteEmpty: true,
+            },
+            {
+                xtype: 'menuseparator',
+            },
+            {
+                xtype: 'box',
+                html: `<b>${gettext('S3 traffic volume:')}</b>`,
+                padding: '10 0 5 0',
+            },
+            {
+                xtype: 'pmxSizeField',
+                name: 's3-upload',
+                fieldLabel: gettext('Upload'),
+                unit: 'GiB',
+                submitAutoScaledSizeUnit: true,
+                allowZero: false,
+                emptyText: gettext('none'),
+            },
+            {
+                xtype: 'pmxSizeField',
+                name: 's3-download',
+                fieldLabel: gettext('Download'),
+                unit: 'GiB',
+                submitAutoScaledSizeUnit: true,
+                allowZero: false,
+                emptyText: gettext('none'),
+            },
+        ],
+    },
+});
-- 
2.47.3





  parent reply	other threads:[~2026-03-03 15:23 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-03 15:22 [PATCH proxmox{,-backup} v4 00/35] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 01/13] proxmox-sys: expose msync to flush mmapped contents to filesystem Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 02/13] shared-memory: add method without tmpfs check for mmap file location Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 03/13] shared-memory: expose msync to flush in-memory contents to filesystem Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 04/13] s3-client: add persistent shared request counters for client Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 05/13] s3-client: add counters for upload/download traffic Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 06/13] s3-client: account for upload traffic on successful request sending Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 07/13] s3-client: account for downloaded bytes in incoming response body Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 08/13] s3-client: request counters: periodically persist counters to file Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 09/13] s3-client: sync flush request counters on client instance drop Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 10/13] pbs-api-types: define api type for s3 request statistics Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 11/13] s3-client: api-types: define request counter thresholds Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 12/13] pbs-api-types: add notification thresholds to datastore config Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox v4 13/13] s3-client: implement request counter threshold and exceeding callback Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox-backup v4 01/22] metrics: split common module imports into individual use statements Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox-backup v4 02/22] datastore: collect request statistics for s3 backed datastores Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox-backup v4 03/22] datastore: expose request counters " Christian Ebner
2026-03-03 15:22 ` [PATCH proxmox-backup v4 04/22] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 05/22] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 06/22] datastore: add helper method to get datastore backend type Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 07/22] ui: improve variable name indirectly fixing typo Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 08/22] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 09/22] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 10/22] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 11/22] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 12/22] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 13/22] datastore: make operation non-optional in lookups Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 14/22] datastore: refactor datastore lookup parameters into dedicated type Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 15/22] datastore: refactor shared request counter loading into helper Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 16/22] api: config: update notification thresholds for config and counters Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 17/22] ui: utils: add helper to render notification threshold property string Christian Ebner
2026-03-03 15:23 ` Christian Ebner [this message]
2026-03-03 15:23 ` [PATCH proxmox-backup v4 19/22] notifications: template data: fix typos in docstrings Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 20/22] notification: define templates and template data for thresholds Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 21/22] datastore: add thresholds notification callback on datastore lookup Christian Ebner
2026-03-03 15:23 ` [PATCH proxmox-backup v4 22/22] api/ui: notifications: add 'thresholds' as notification type value Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260303152317.934256-32-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal