public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 proxmox-backup 00/11] fix various warnings
Date: Thu, 26 Feb 2026 15:40:14 +0100	[thread overview]
Message-ID: <20260226144033.211039-1-r.obkircher@proxmox.com> (raw)

The first 10 patches fix all clippy warnings expect the one about
future incompatibilities in the num-bigint-dig v0.8.4 depencency.

The last patch is an attempt at fixing the compiler warnings about the
deprecated flock function, but I'm not sure if this is an acceptable
solution.

Robert Obkircher (11):
  datastore: remove allow(clippy::cast_ptr_alignment) attribute
  api: use checked_div for compression ratio calculation
  datastore+server: sort by key instead of using comparison functions
  api: remove unnecessary ampersand to fix clippy warning
  bin: debug: use pattern match instead of is_some+unwrap
  bin: proxy: fix clippy warning about unnecesary use of find_map
  datastore: silence warning about too many arguments
  client: catalog shell: avoid unnecessary block_on in async code
  client: catalog shell: combine multiple block_on calls into one
  client: catalog shell: avoid unsafe transmute
  tape: media catalog: use Flock wrapper instead of deprecated function

 pbs-client/src/catalog_shell.rs         | 124 +++++++++++++-----------
 pbs-datastore/src/backup_info.rs        |   4 +-
 pbs-datastore/src/chunk_store.rs        |   1 +
 pbs-datastore/src/datastore.rs          |   4 +-
 pbs-datastore/src/dynamic_index.rs      |   1 -
 src/api2/backup/environment.rs          |   7 +-
 src/api2/node/certificates.rs           |   2 +-
 src/bin/proxmox-backup-proxy.rs         |   4 +-
 src/bin/proxmox_backup_debug/inspect.rs |  12 ++-
 src/server/pull.rs                      |   2 +-
 src/server/push.rs                      |   2 +-
 src/tape/media_catalog.rs               |  49 +++++-----
 12 files changed, 112 insertions(+), 100 deletions(-)

-- 
2.47.3





             reply	other threads:[~2026-02-26 14:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-26 14:40 Robert Obkircher [this message]
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 01/11] datastore: remove allow(clippy::cast_ptr_alignment) attribute Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 02/11] api: use checked_div for compression ratio calculation Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 03/11] datastore+server: sort by key instead of using comparison functions Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 04/11] api: remove unnecessary ampersand to fix clippy warning Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 05/11] bin: debug: use pattern match instead of is_some+unwrap Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 06/11] bin: proxy: fix clippy warning about unnecesary use of find_map Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 07/11] datastore: silence warning about too many arguments Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 08/11] client: catalog shell: avoid unnecessary block_on in async code Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 09/11] client: catalog shell: combine multiple block_on calls into one Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 10/11] client: catalog shell: avoid unsafe transmute Robert Obkircher
2026-02-26 14:40 ` [PATCH v1 proxmox-backup 11/11] tape: media catalog: use Flock wrapper instead of deprecated function Robert Obkircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260226144033.211039-1-r.obkircher@proxmox.com \
    --to=r.obkircher@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal