From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v3 01/10] proxmox-sys: expose msync to flush mmapped contents to filesystem
Date: Tue, 24 Feb 2026 10:13:45 +0100 [thread overview]
Message-ID: <20260224091406.169080-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260224091406.169080-1-c.ebner@proxmox.com>
Allows to flush all in-memory contents of the mmapped file back to
the filesystem using msync [0] given the semantics provided via the
`MS_*` flags.
Without this the contents are not guaranteed to be persisted to the
backing file until unmapped, which could lead to data loss on system
crash or OOM situations.
[0] https://man7.org/linux/man-pages/man2/msync.2.html
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-sys/src/mmap.rs | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/proxmox-sys/src/mmap.rs b/proxmox-sys/src/mmap.rs
index 8b8ad8a6..e15ca1db 100644
--- a/proxmox-sys/src/mmap.rs
+++ b/proxmox-sys/src/mmap.rs
@@ -56,6 +56,18 @@ impl<T> Mmap<T> {
len: count,
})
}
+
+ /// Flush all in-memory contents to the backing file.
+ pub fn msync(&self, flags: mman::MsFlags) -> io::Result<()> {
+ unsafe {
+ mman::msync(
+ self.data.cast::<core::ffi::c_void>(),
+ self.len * mem::size_of::<T>(),
+ flags,
+ )
+ }
+ .map_err(SysError::into_io_error)
+ }
}
impl<T> std::ops::Deref for Mmap<T> {
--
2.47.3
next prev parent reply other threads:[~2026-02-24 9:13 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 9:13 [PATCH proxmox{,-backup} v3 00/22] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-02-24 9:13 ` Christian Ebner [this message]
2026-02-24 9:13 ` [PATCH proxmox v3 02/10] shared-memory: add method without tmpfs check for mmap file location Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 03/10] shared-memory: expose msync to flush in-memory contents to filesystem Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 04/10] s3-client: add persistent shared request counters for client Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 05/10] s3-client: add counters for upload/download traffic Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 06/10] s3-client: account for upload traffic on successful request sending Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 07/10] s3-client: account for downloaded bytes in incoming response body Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 08/10] s3-client: request counters: periodically persist counters to file Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 09/10] s3-client: sync flush request counters on client instance drop Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox v3 10/10] pbs-api-types: define api type for s3 request statistics Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 01/12] metrics: split common module imports into individual use statements Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 02/12] datastore: collect request statistics for s3 backed datastores Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 03/12] datastore: expose request counters " Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 04/12] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-02-24 9:13 ` [PATCH proxmox-backup v3 05/12] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 06/12] datastore: add helper method to get datastore backend type Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 07/12] ui: improve variable name indirectly fixing typo Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 08/12] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 09/12] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 10/12] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 11/12] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-02-24 9:14 ` [PATCH proxmox-backup v3 12/12] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260224091406.169080-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox