From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH backup 0/2] fix #7054: client: remove trailing newlines from credentials
Date: Fri, 20 Feb 2026 12:17:09 +0100 [thread overview]
Message-ID: <20260220111951.280082-1-m.sandoval@proxmox.com> (raw)
See the first commit for more details.
This was tested with proxmox-backup-client making a login/backup using different
credentials with and without newlines. The commands were similar to the
systemd-run commands at the Backup Client Usage docs.
I did not find a way to create the keyfile with newlines in its password using
proxmox-backup-client since it reads from the tty stdin, but surely it could be
created manually. Perhaps it is safe-ish to also remove trailing control
characters from the encryption password but this seems a safer approach for now.
Maximiliano Sandoval (2):
fix #7054: client: remove trailing newlines from credentials
docs: client: document further password constrains
docs/backup-client.rst | 7 ++++---
pbs-client/src/tools/mod.rs | 11 +++++++++++
2 files changed, 15 insertions(+), 3 deletions(-)
--
2.47.3
next reply other threads:[~2026-02-20 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-20 11:17 Maximiliano Sandoval [this message]
2026-02-20 11:17 ` [PATCH backup 1/2] " Maximiliano Sandoval
2026-02-20 12:05 ` Christian Ebner
2026-02-20 12:21 ` Maximiliano Sandoval
2026-02-20 12:23 ` Fabian Grünbichler
2026-02-20 11:17 ` [PATCH backup 2/2] docs: client: document further password constrains Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260220111951.280082-1-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox