public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH proxmox v2 3/6] s3-client: add counters for upload/download traffic
Date: Mon, 16 Feb 2026 13:13:51 +0100	[thread overview]
Message-ID: <20260216121406.99617-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260216121406.99617-1-c.ebner@proxmox.com>

In addition to accounting for requests, also allow to track the
number of bytes uploaded or downloaded via the s3 clients.

With the intention to estimate shared upload/download bandwidth in
Proxmox Backup Server as well as easily estimate the total traffic
volume.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1:
- Use of aligned atomic counters

 .../src/shared_request_counters.rs            | 63 +++++++++++++++++++
 1 file changed, 63 insertions(+)

diff --git a/proxmox-s3-client/src/shared_request_counters.rs b/proxmox-s3-client/src/shared_request_counters.rs
index ec587a07..e37829f0 100644
--- a/proxmox-s3-client/src/shared_request_counters.rs
+++ b/proxmox-s3-client/src/shared_request_counters.rs
@@ -37,6 +37,9 @@ struct RequestCounters {
     put: AlignedAtomic,
     head: AlignedAtomic,
     post: AlignedAtomic,
+    // traffic in bytes
+    upload: AlignedAtomic,
+    download: AlignedAtomic,
 }
 
 impl Init for RequestCounters {
@@ -81,6 +84,30 @@ impl RequestCounters {
         self.post.0.store(0, ordering);
         self.put.0.store(0, ordering);
     }
+
+    /// Account for new upload traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.upload.0.fetch_add(count, ordering)
+    }
+
+    /// Returns upload traffic count.
+    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
+        self.upload.0.load(ordering)
+    }
+
+    /// Account for new download traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.download.0.fetch_add(count, ordering)
+    }
+
+    /// Returns download traffic count.
+    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
+        self.download.0.load(ordering)
+    }
 }
 
 /// Size of the padding to align the mmapped request counters to 4k default
@@ -181,4 +208,40 @@ impl SharedRequestCounters {
     pub fn reset(&self, ordering: Ordering) {
         self.shared_memory.data().counters.reset(ordering)
     }
+
+    /// Account for new upload traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .add_upload_traffic(count, ordering)
+    }
+
+    /// Returns upload traffic count.
+    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .get_upload_traffic(ordering)
+    }
+
+    /// Account for new download traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .add_download_traffic(count, ordering)
+    }
+
+    /// Returns download traffic count.
+    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .get_download_traffic(ordering)
+    }
 }
-- 
2.47.3





  parent reply	other threads:[~2026-02-16 12:14 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-16 12:13 [PATCH proxmox{,-backup} v2 00/18] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox v2 1/6] shared-memory: add method without tmpfs check for mmap file location Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox v2 2/6] s3-client: add persistent shared request counters for client Christian Ebner
2026-02-16 12:13 ` Christian Ebner [this message]
2026-02-16 12:13 ` [PATCH proxmox v2 4/6] s3-client: account for upload traffic on successful request sending Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox v2 5/6] s3-client: account for downloaded bytes in incoming response body Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox v2 6/6] pbs-api-types: define api type for s3 request statistics Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox-backup v2 01/12] metrics: split common module imports into individual use statements Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox-backup v2 02/12] datastore: collect request statistics for s3 backed datastores Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox-backup v2 03/12] datastore: expose request counters " Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox-backup v2 04/12] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-02-16 12:13 ` [PATCH proxmox-backup v2 05/12] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 06/12] datastore: add helper method to get datastore backend type Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 07/12] ui: improve variable name indirectly fixing typo Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 08/12] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 09/12] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 10/12] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 11/12] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-02-16 12:14 ` [PATCH proxmox-backup v2 12/12] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260216121406.99617-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal