[PATCH proxmox{,-backup} v2 00/18] partially fix #6563: add s3 request and traffic counter statistics

[Christian Ebner <c.ebner@proxmox.com>]

This patch series implements request and traffic counters for the s3
client, being shared as atomic counters via shared memory and mmapping
across all s3-client instances.

The shared counters are instantiated on demand for individual
datastores with s3 backend on s3 client instantiation and stored as
part of the datastore implementation by loading the mmapped file on
datastore instantiation, being cached for further access.

Further, counters are being loaded during rrd metrics collection and
exposed as charts in the datastore summary, including the total
request counts per method, the total upload and download traffic as
well as the averaged upload and download rate.

Usage statistics for the s3 backend are not included in this series
an will be tackled as followup series.

Changes since version 1 (thanks @Robert for feedback):
- Keep tmpfs check in shmem mapping for pre-existing code, add
  dedicated methods to create mmapped files in persistent locations.
- Reorder and align atomic counters to 32-byte (half default cache
  line size) to reduce false sharing.
- Rework request counter init logic, avoid unsafe code and undefined
  behaviour.
- Rework page size calculation based on new counter alignment.
- Avoid the need to open and mmap counter file for each rrd data
  collection, keep the per-datastores filehandle cached instead.

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=6563


proxmox:

Christian Ebner (6):
  shared-memory: add method without tmpfs check for mmap file location
  s3-client: add persistent shared request counters for client
  s3-client: add counters for upload/download traffic
  s3-client: account for upload traffic on successful request sending
  s3-client: account for downloaded bytes in incoming response body
  pbs-api-types: define api type for s3 request statistics

 pbs-api-types/src/datastore.rs                |  28 ++
 proxmox-s3-client/Cargo.toml                  |   4 +
 proxmox-s3-client/debian/control              |   2 +
 proxmox-s3-client/examples/s3_client.rs       |   1 +
 proxmox-s3-client/src/client.rs               |  70 ++++-
 proxmox-s3-client/src/lib.rs                  |   7 +-
 proxmox-s3-client/src/response_reader.rs      |  75 +++++-
 .../src/shared_request_counters.rs            | 247 ++++++++++++++++++
 proxmox-shared-memory/src/lib.rs              |  41 ++-
 9 files changed, 457 insertions(+), 18 deletions(-)
 create mode 100644 proxmox-s3-client/src/shared_request_counters.rs


proxmox-backup:

Christian Ebner (12):
  metrics: split common module imports into individual use statements
  datastore: collect request statistics for s3 backed datastores
  datastore: expose request counters for s3 backed datastores
  api: s3: add endpoint to reset s3 request counters
  bin: s3: expose request counter reset method as cli command
  datastore: add helper method to get datastore backend type
  ui: improve variable name indirectly fixing typo
  ui: datastore summary: move store to be part of summary panel
  ui: expose s3 request counter statistics in the datastore summary
  metrics: collect s3 datastore statistics as rrd metrics
  api: admin: expose s3 statistics in datastore rrd data
  partially fix #6563: ui: expose s3 rrd charts in datastore summary

 pbs-datastore/src/datastore.rs                |  66 +++-
 pbs-datastore/src/lib.rs                      |   2 +-
 src/api2/admin/datastore.rs                   |  23 +-
 src/api2/admin/s3.rs                          |  86 ++++-
 src/api2/config/s3.rs                         |  18 +-
 src/bin/proxmox_backup_manager/s3.rs          |  33 ++
 src/server/metric_collection/metric_server.rs |   8 +-
 src/server/metric_collection/mod.rs           | 108 +++++-
 src/server/metric_collection/pull_metrics.rs  |  18 +-
 src/server/metric_collection/rrd.rs           |  34 +-
 www/datastore/Summary.js                      | 341 ++++++++++++------
 11 files changed, 587 insertions(+), 150 deletions(-)


Summary over all repositories:
  20 files changed, 1044 insertions(+), 168 deletions(-)

-- 
Generated by murpp 0.9.0