From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client
Date: Tue, 10 Feb 2026 16:06:16 +0100 [thread overview]
Message-ID: <20260210150642.469670-1-r.obkircher@proxmox.com> (raw)
Add support for commands like:
ssh host cmd | proxmox-backup-client backup data.img:/dev/stdin
proxmox-backup-client backup a.img:<(mysqldump) b.img:<(pgdump)
Changes since v5:
Client:
- add IndexType::to_prefix_and_size helper and fix format string nit
- drop support for '-' but log helpful warnings
- fail early for duplicate pipes
- avoid calling poll_next on terminated streams
Server:
- mention why Arc<ChunkStore> can be removed from didx as well
- (Test)TempDir:
- add to parent mod in earlier commit
- drop "Test" from the name
- improved API so it could be moved to a crate (no unwrap in new,
no Deref, no impl From<&TempDir> for PathBuf)
- added tests
- reorder add_chunk commit before grow_to_size
- support reuse-csum with arbitrary sizes
- made up my mind on u32 vs u64 and reordered commits
- check that chunk_size is power of two
Robert Obkircher (18):
datastore: remove Arc<ChunkStore> from FixedIndexWriter
datastore: remove Arc<ChunkStore> from DynamicIndexWriter
datastore: add TempDir that is automatically deleted on drop
datastore: use temporary directory for chunk store test
datastore: combine public FixedIndexWriter methods into add_chunk
datastore: use fixed size types for FixedIndexWriter
datastore: verify that chunk_size is a power of two
datastore: support writing fidx files of unknown size
datastore: test FixedIndexWriter
api: backup: make fixed index file size optional
api: verify fixed index writer size on close
client: don't poll terminated source in FixedChunkStream
client: don't poll terminated source in ChunkStream
fix #3847: client: support fifo pipe inputs for image backups
client: Fail early if the same pipe is specified for multiple inputs
datastore: compute fidx file size with overflow checks
datastore: support writing fidx files on systems with larger page size
datastore: support incremental fidx uploads with different size
pbs-client/src/backup_writer.rs | 37 ++-
pbs-client/src/chunk_stream.rs | 23 +-
pbs-datastore/src/chunk_store.rs | 14 +-
pbs-datastore/src/datastore.rs | 19 +-
pbs-datastore/src/dynamic_index.rs | 5 +-
pbs-datastore/src/fixed_index.rs | 513 +++++++++++++++++++++++++----
pbs-datastore/src/lib.rs | 3 +
pbs-datastore/src/temp_dir.rs | 142 ++++++++
proxmox-backup-client/src/main.rs | 55 +++-
src/api2/backup/environment.rs | 37 ++-
src/api2/backup/mod.rs | 6 +-
src/server/push.rs | 11 +-
12 files changed, 725 insertions(+), 140 deletions(-)
create mode 100644 pbs-datastore/src/temp_dir.rs
--
2.47.3
next reply other threads:[~2026-02-10 15:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 15:06 Robert Obkircher [this message]
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 01/18] datastore: remove Arc<ChunkStore> from FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 02/18] datastore: remove Arc<ChunkStore> from DynamicIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 03/18] datastore: add TempDir that is automatically deleted on drop Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 04/18] datastore: use temporary directory for chunk store test Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 05/18] datastore: combine public FixedIndexWriter methods into add_chunk Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 06/18] datastore: use fixed size types for FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 07/18] datastore: verify that chunk_size is a power of two Robert Obkircher
2026-02-17 9:13 ` Robert Obkircher
2026-02-17 9:40 ` Christian Ebner
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 08/18] datastore: support writing fidx files of unknown size Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 09/18] datastore: test FixedIndexWriter Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 10/18] api: backup: make fixed index file size optional Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 11/18] api: verify fixed index writer size on close Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 12/18] client: don't poll terminated source in FixedChunkStream Robert Obkircher
2026-02-17 10:01 ` Christian Ebner
2026-02-17 10:06 ` Christian Ebner
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 13/18] client: don't poll terminated source in ChunkStream Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 14/18] fix #3847: client: support fifo pipe inputs for image backups Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 15/18] client: Fail early if the same pipe is specified for multiple inputs Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 16/18] datastore: compute fidx file size with overflow checks Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 17/18] datastore: support writing fidx files on systems with larger page size Robert Obkircher
2026-02-10 15:06 ` [PATCH v6 proxmox-backup 18/18] datastore: support incremental fidx uploads with different size Robert Obkircher
2026-02-17 12:42 ` [PATCH v6 proxmox-backup 00/18] fix: #3847 pipe from STDIN to proxmox-backup-client Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260210150642.469670-1-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox