public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v1 3/6] s3-client: add counters for upload/download traffic
Date: Mon,  9 Feb 2026 10:15:19 +0100	[thread overview]
Message-ID: <20260209091533.156902-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20260209091533.156902-1-c.ebner@proxmox.com>

In addition to accounting for requests, also allow to track the
number of bytes uploaded or downloaded via the s3 clients.

With the intention to estimate shared upload/download bandwidth in
Proxmox Backup Server as well as easily estimate the total traffic
volume.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 .../src/shared_request_counters.rs            | 64 +++++++++++++++++++
 1 file changed, 64 insertions(+)

diff --git a/proxmox-s3-client/src/shared_request_counters.rs b/proxmox-s3-client/src/shared_request_counters.rs
index b236490b..b3a43a0b 100644
--- a/proxmox-s3-client/src/shared_request_counters.rs
+++ b/proxmox-s3-client/src/shared_request_counters.rs
@@ -17,11 +17,15 @@ const PROXMOX_SHARED_REQUEST_COUNTERS_1_0: [u8; 8] = [224, 110, 88, 252, 26, 77,
 #[repr(C)]
 #[derive(Default)]
 struct RequestCounters {
+    // request count
     delete: AtomicU64,
     get: AtomicU64,
     head: AtomicU64,
     post: AtomicU64,
     put: AtomicU64,
+    // traffic in bytes
+    upload: AtomicU64,
+    download: AtomicU64,
 }
 
 impl Init for RequestCounters {
@@ -68,6 +72,30 @@ impl RequestCounters {
         self.post.store(0, ordering);
         self.put.store(0, ordering);
     }
+
+    /// Account for new upload traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.upload.fetch_add(count, ordering)
+    }
+
+    /// Returns upload traffic count.
+    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
+        self.upload.load(ordering)
+    }
+
+    /// Account for new download traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.download.fetch_add(count, ordering)
+    }
+
+    /// Returns download traffic count.
+    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
+        self.download.load(ordering)
+    }
 }
 
 #[repr(C)]
@@ -149,4 +177,40 @@ impl SharedRequestCounters {
     pub fn reset(&self, ordering: Ordering) {
         self.shared_memory.data().counters.reset(ordering)
     }
+
+    /// Account for new upload traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_upload_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .add_upload_traffic(count, ordering)
+    }
+
+    /// Returns upload traffic count.
+    pub fn get_upload_traffic(&self, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .get_upload_traffic(ordering)
+    }
+
+    /// Account for new download traffic.
+    ///
+    /// Returns the previously stored value.
+    pub fn add_download_traffic(&self, count: u64, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .add_download_traffic(count, ordering)
+    }
+
+    /// Returns download traffic count.
+    pub fn get_download_traffic(&self, ordering: Ordering) -> u64 {
+        self.shared_memory
+            .data()
+            .counters
+            .get_download_traffic(ordering)
+    }
 }
-- 
2.47.3





  parent reply	other threads:[~2026-02-09  9:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09  9:15 [PATCH v1 00/17] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-02-09  9:15 ` [PATCH v1 1/6] shared-memory: drop check for mmap file being located on tmpfs Christian Ebner
2026-02-09  9:15 ` [PATCH v1 2/6] s3-client: add persistent shared request counters for client Christian Ebner
2026-02-11 12:13   ` Robert Obkircher
2026-02-11 12:41     ` Christian Ebner
2026-02-12  9:55       ` Robert Obkircher
2026-02-12 10:19         ` Christian Ebner
2026-02-13 13:37         ` Christian Ebner
2026-02-09  9:15 ` Christian Ebner [this message]
2026-02-09  9:15 ` [PATCH v1 4/6] s3-client: account for upload traffic on successful request sending Christian Ebner
2026-02-09  9:15 ` [PATCH v1 5/6] s3-client: account for downloaded bytes in incoming response body Christian Ebner
2026-02-09  9:15 ` [PATCH v1 6/6] pbs-api-types: define api type for s3 request statistics Christian Ebner
2026-02-09  9:15 ` [PATCH v1 01/11] datastore: collect request statistics for s3 backed datastores Christian Ebner
2026-02-09  9:15 ` [PATCH v1 02/11] datastore: expose request counters " Christian Ebner
2026-02-09  9:15 ` [PATCH v1 03/11] api: s3: add endpoint to reset s3 request counters Christian Ebner
2026-02-09  9:15 ` [PATCH v1 04/11] bin: s3: expose request counter reset method as cli command Christian Ebner
2026-02-09  9:15 ` [PATCH v1 05/11] datastore: add helper method to get datastore backend type Christian Ebner
2026-02-09  9:15 ` [PATCH v1 06/11] ui: improve variable name indirectly fixing typo Christian Ebner
2026-02-09  9:15 ` [PATCH v1 07/11] ui: datastore summary: move store to be part of summary panel Christian Ebner
2026-02-09  9:15 ` [PATCH v1 08/11] ui: expose s3 request counter statistics in the datastore summary Christian Ebner
2026-02-09  9:15 ` [PATCH v1 09/11] metrics: collect s3 datastore statistics as rrd metrics Christian Ebner
2026-02-11 16:29   ` Christian Ebner
2026-02-09  9:15 ` [PATCH v1 10/11] api: admin: expose s3 statistics in datastore rrd data Christian Ebner
2026-02-09  9:15 ` [PATCH v1 11/11] partially fix #6563: ui: expose s3 rrd charts in datastore summary Christian Ebner
2026-02-09  9:39 ` [PATCH v1 00/17] partially fix #6563: add s3 request and traffic counter statistics Christian Ebner
2026-02-16 12:15 ` superseded: " Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260209091533.156902-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal