From: Robert Obkircher <r.obkircher@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [PATCH v5 proxmox-backup 00/16] fix: #3847 pipe from STDIN to proxmox-backup-client
Date: Fri, 30 Jan 2026 17:45:24 +0100 [thread overview]
Message-ID: <20260130164552.281581-1-r.obkircher@proxmox.com> (raw)
Add support for commands like:
ssh host cmd | proxmox-backup-client backup data.img:/dev/stdin
proxmox-backup-client backup a.img:<(mysqldump) b.img:<(pgdump)
Changes since v4:
- reordered the ChunkStore removal commit and adjusted dynamic writer
- moved TempTestDir into separate file, use it for test_chunk_store1
- improved commit messages and comments
- changed u32 param to u64
- removed unnecessary casts reported by clippy
- added two commits at the end which restrict chunk_size to u32
(I'd fixup commit 12/16 if we actually want to keep those changes)
An open question is if we should maybe fsync the data before renaming.
Or is that too much overhead for slightly better crash consistency?
Robert Obkircher (16):
datastore: remove Arc<ChunkStore> from FixedIndexWriter
datastore: remove Arc<ChunkStore> from DynamicIndexWriter
datastore: add TempTestDir that is automatically deleted on drop
datastore: use temporary directory for chunk store test
datastore: support writing fidx files of unknown size
datastore: test FixedIndexWriter
api: backup: make fixed index file size optional
api: verify fixed index writer size on close
fix #3847: client: support fifo pipe inputs for images
client: treat minus sign as stdin
datastore: combine public FixedIndexWriter methods into add_chunk.
datastore: use u64 instead of usize for fidx writer content size
datastore: compute fidx file size with overflow checks
datastore: support writing fidx files on systems with larger page size
datastore: FixedIndexWriter: switch public chunk_size to u32
datastore: FixedIndexWriter: switch internal chunk_size to u32
pbs-client/src/backup_writer.rs | 38 ++-
pbs-datastore/src/chunk_store.rs | 7 +-
pbs-datastore/src/datastore.rs | 19 +-
pbs-datastore/src/dynamic_index.rs | 5 +-
pbs-datastore/src/fixed_index.rs | 435 +++++++++++++++++++++++++----
pbs-datastore/src/lib.rs | 3 +
pbs-datastore/src/temp_test_dir.rs | 33 +++
proxmox-backup-client/src/main.rs | 37 ++-
src/api2/backup/environment.rs | 33 ++-
src/api2/backup/mod.rs | 6 +-
src/server/push.rs | 11 +-
11 files changed, 499 insertions(+), 128 deletions(-)
create mode 100644 pbs-datastore/src/temp_test_dir.rs
--
2.47.3
next reply other threads:[~2026-01-30 16:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 16:45 Robert Obkircher [this message]
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 01/16] datastore: remove Arc<ChunkStore> from FixedIndexWriter Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 02/16] datastore: remove Arc<ChunkStore> from DynamicIndexWriter Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 03/16] datastore: add TempTestDir that is automatically deleted on drop Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 04/16] datastore: use temporary directory for chunk store test Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 05/16] datastore: support writing fidx files of unknown size Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 06/16] datastore: test FixedIndexWriter Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 07/16] api: backup: make fixed index file size optional Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 08/16] api: verify fixed index writer size on close Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 09/16] fix #3847: client: support fifo pipe inputs for images Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 10/16] client: treat minus sign as stdin Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 11/16] datastore: combine public FixedIndexWriter methods into add_chunk Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 12/16] datastore: use u64 instead of usize for fidx writer content size Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 13/16] datastore: compute fidx file size with overflow checks Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 14/16] datastore: support writing fidx files on systems with larger page size Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 15/16] datastore: FixedIndexWriter: switch public chunk_size to u32 Robert Obkircher
2026-01-30 16:45 ` [PATCH v5 proxmox-backup 16/16] datastore: FixedIndexWriter: switch internal " Robert Obkircher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260130164552.281581-1-r.obkircher@proxmox.com \
--to=r.obkircher@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox