public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [RFC proxmox{,-backup} 0/3] fix #6373: HTTP level keepalive for http2 backup reader connection
Date: Thu, 29 Jan 2026 13:26:57 +0100	[thread overview]
Message-ID: <20260129122700.448448-1-c.ebner@proxmox.com> (raw)

Patches implement a HTTP level keepalive mechanism to avoid of active
but idle http2 connections established by the backup reader being
dropped by reverse proxies.
Regular heartbeat requests are send to the Proxmox Backup Server, the
frequency based on a given timeout. Heartbeat traffic is only send if
no other requests have been send during the timeout period. The
timeout given in seconds is read from the
PBS_READER_HEARTBEAT_TIMEOUT environment variable, if not set no
heartbeat traffic is being send.

Since each HTTP request is being logged to the task log for http2
connections, implement a filtering logic allowing to exclude these
request logs to avoid log flodding.

If the chosen approach is acceptable, the timeout value might also
be passed as optional parameter on command invocation as well and
exposed in PVE as advanced parameter, although only important if
proxies are being used.

Example configurations for testing can be found on the individual
patch fixing the issue.

Link to the bugtracker issue:
https://bugzilla.proxmox.com/show_bug.cgi?id=6373

proxmox:

Christian Ebner (1):
  rest-server: add request logfilter by method and path in h2 service

 proxmox-rest-server/src/h2service.rs | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)


proxmox-backup:

Christian Ebner (2):
  fix #6373: HTTP level reader heartbeat for proxy connection keepalive
  api: h2service: avoid logging heartbeat requests to task log

 pbs-client/src/backup_reader.rs | 69 ++++++++++++++++++++++++++++++---
 src/api2/backup/mod.rs          |  2 +-
 src/api2/reader/mod.rs          | 22 +++++++++--
 3 files changed, 84 insertions(+), 9 deletions(-)


Summary over all repositories:
  4 files changed, 100 insertions(+), 11 deletions(-)

-- 
Generated by git-murpp 0.8.1




             reply	other threads:[~2026-01-29 12:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-29 12:26 Christian Ebner [this message]
2026-01-29 12:26 ` [PATCH proxmox 1/1] rest-server: add request logfilter by method and path in h2 service Christian Ebner
2026-01-29 12:26 ` [PATCH proxmox-backup 1/2] fix #6373: HTTP level reader heartbeat for proxy connection keepalive Christian Ebner
2026-01-29 12:27 ` [PATCH proxmox-backup 2/2] api: h2service: avoid logging heartbeat requests to task log Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260129122700.448448-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal