From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 8/8] router: replace clone with std::slice::from_ref
Date: Tue, 9 Dec 2025 11:52:48 +0100 [thread overview]
Message-ID: <20251209105252.241312-8-m.sandoval@proxmox.com> (raw)
In-Reply-To: <20251209105252.241312-1-m.sandoval@proxmox.com>
This does not clone nor copy.
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
proxmox-router/src/cli/completion.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-router/src/cli/completion.rs b/proxmox-router/src/cli/completion.rs
index 091463de..2569f9a8 100644
--- a/proxmox-router/src/cli/completion.rs
+++ b/proxmox-router/src/cli/completion.rs
@@ -484,7 +484,7 @@ impl CompletionParser {
// with no arguments remaining, the final global argument could need completion:
if let Some((option, argument)) = global_args.last() {
if let Some(completion) =
- self.try_complete_global_property(option, &[argument.clone()])
+ self.try_complete_global_property(option, std::slice::from_ref(argument))
{
return Ok(GlobalArgs::Completed(completion));
}
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-12-09 10:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-09 10:52 [pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87 Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 2/8] don't hide a lifetimes that are elided elsewhere Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 3/8] auth-api: remove unnecessary return Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 4/8] deb-version: remove unnecesary vec! call Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 5/8] fixed-string: remove unused import Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 6/8] rest-server: " Maximiliano Sandoval
2025-12-09 10:52 ` [pbs-devel] [PATCH proxmox 7/8] http: remove unnecessary conversion Maximiliano Sandoval
2025-12-09 10:52 ` Maximiliano Sandoval [this message]
2025-12-09 16:22 ` [pbs-devel] [PATCH proxmox 1/8] cargo: bump msrv to 1.87 Thomas Lamprecht
2025-12-10 8:40 ` Maximiliano Sandoval
2025-12-10 9:02 ` Thomas Lamprecht
2025-12-10 10:57 ` [pbs-devel] superseded: " Maximiliano Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251209105252.241312-8-m.sandoval@proxmox.com \
--to=m.sandoval@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox