From: Nicolas Frey <n.frey@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v2 1/1] pbs-api-types: add default-verification-{workers, readers} to tuning options
Date: Mon, 24 Nov 2025 12:04:21 +0100 [thread overview]
Message-ID: <20251124110427.194887-2-n.frey@proxmox.com> (raw)
In-Reply-To: <20251124110427.194887-1-n.frey@proxmox.com>
to determine the default number of threads to use for verify jobs on
the datastore level
Reviewed-by: Christian Ebner <c.ebner@proxmox.com>
Tested-by: Christian Ebner <c.ebner@proxmox.com>
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
Changes since v1:
* rename the user-facing parameters to
`default-verification-{workers,readers}`
pbs-api-types/src/datastore.rs | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index a214ac25..c17452a8 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -19,7 +19,8 @@ use crate::{
BACKUP_ID_RE, BACKUP_NS_RE, BACKUP_TIME_RE, BACKUP_TYPE_RE, DATASTORE_NOTIFY_STRING_SCHEMA,
GC_SCHEDULE_SCHEMA, GROUP_OR_SNAPSHOT_PATH_REGEX_STR, PROXMOX_SAFE_ID_FORMAT,
PROXMOX_SAFE_ID_REGEX_STR, PRUNE_SCHEDULE_SCHEMA, SHA256_HEX_REGEX, SINGLE_LINE_COMMENT_SCHEMA,
- SNAPSHOT_PATH_REGEX_STR, UPID,
+ SNAPSHOT_PATH_REGEX_STR, UPID, VERIFY_JOB_READ_THREADS_SCHEMA,
+ VERIFY_JOB_VERIFY_THREADS_SCHEMA,
};
const_regex! {
@@ -262,6 +263,14 @@ pub const GC_CACHE_CAPACITY_SCHEMA: Schema =
schema: GC_CACHE_CAPACITY_SCHEMA,
optional: true,
},
+ "default-verification-workers": {
+ schema: VERIFY_JOB_VERIFY_THREADS_SCHEMA,
+ optional: true,
+ },
+ "default-verification-readers": {
+ schema: VERIFY_JOB_READ_THREADS_SCHEMA,
+ optional: true,
+ },
},
)]
#[derive(Serialize, Deserialize, Default)]
@@ -279,6 +288,10 @@ pub struct DatastoreTuning {
pub gc_atime_cutoff: Option<usize>,
#[serde(skip_serializing_if = "Option::is_none")]
pub gc_cache_capacity: Option<usize>,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub default_verification_workers: Option<usize>,
+ #[serde(skip_serializing_if = "Option::is_none")]
+ pub default_verification_readers: Option<usize>,
}
pub const DATASTORE_TUNING_STRING_SCHEMA: Schema = StringSchema::new("Datastore tuning options")
--
2.47.3
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-11-24 11:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-24 11:04 [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] tuning: verify: add verify job thread options Nicolas Frey
2025-11-24 11:04 ` Nicolas Frey [this message]
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 1/6] datastore: add new thread settings to tuning options Nicolas Frey
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 2/6] verify: use tuning options' thread settings for {verify, read}-threads Nicolas Frey
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 3/6] ui: tuning: make default-verification-{workers, readers} configurable Nicolas Frey
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 4/6] ui: tuning: render verification threads in tuning options Nicolas Frey
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 5/6] ui: verify: fetch default {read, verify} thread values from " Nicolas Frey
2025-11-24 11:04 ` [pbs-devel] [PATCH proxmox-backup v2 6/6] docs: tuning: document default-verification-{workers, readers} Nicolas Frey
2025-11-24 12:41 ` [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] tuning: verify: add verify job thread options Christian Ebner
2025-11-24 14:16 ` [pbs-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251124110427.194887-2-n.frey@proxmox.com \
--to=n.frey@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox