public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v3 4/5] rest-server: optionally depend on factored out shared rate limiter
Date: Wed, 12 Nov 2025 12:53:48 +0100	[thread overview]
Message-ID: <20251112115353.277514-5-c.ebner@proxmox.com> (raw)
In-Reply-To: <20251112115353.277514-1-c.ebner@proxmox.com>

The rate limiter implementation has been moved to a dedicated crate,
so depend on it for the rest servers rate limited stream connection.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Hannes Laimer <h.laimer@proxmox.com>
Tested-by: Hannes Laimer <h.laimer@proxmox.com>
---
Changes since version 2:
- rebased onto current master

 proxmox-rest-server/Cargo.toml        | 2 ++
 proxmox-rest-server/debian/control    | 4 +++-
 proxmox-rest-server/src/connection.rs | 4 +++-
 3 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/proxmox-rest-server/Cargo.toml b/proxmox-rest-server/Cargo.toml
index 81d93ca1..7478f6a8 100644
--- a/proxmox-rest-server/Cargo.toml
+++ b/proxmox-rest-server/Cargo.toml
@@ -44,6 +44,7 @@ proxmox-daemon.workspace = true
 proxmox-http = { workspace = true, features = ["body"] }
 proxmox-lang.workspace = true
 proxmox-log.workspace = true
+proxmox-rate-limiter = { workspace = true, optional = true, features = [ "shared-rate-limiter" ] }
 proxmox-router.workspace = true
 proxmox-schema = { workspace = true, features = [ "api-macro", "upid-api-impl" ] }
 proxmox-sys = { workspace = true, features = [ "logrotate", "timer" ] }
@@ -54,5 +55,6 @@ proxmox-worker-task.workspace = true
 default = []
 templates = ["dep:handlebars"]
 rate-limited-stream = [
+    "dep:proxmox-rate-limiter",
     "proxmox-http/rate-limited-stream",
 ]
diff --git a/proxmox-rest-server/debian/control b/proxmox-rest-server/debian/control
index 78304cef..6433c01b 100644
--- a/proxmox-rest-server/debian/control
+++ b/proxmox-rest-server/debian/control
@@ -137,7 +137,9 @@ Depends:
  ${misc:Depends},
  librust-proxmox-rest-server-dev (= ${binary:Version}),
  librust-proxmox-http-1+body-dev (>= 1.0.3-~~),
- librust-proxmox-http-1+rate-limited-stream-dev (>= 1.0.3-~~)
+ librust-proxmox-http-1+rate-limited-stream-dev (>= 1.0.3-~~),
+ librust-proxmox-rate-limiter-1+default-dev,
+ librust-proxmox-rate-limiter-1+shared-rate-limiter-dev
 Provides:
  librust-proxmox-rest-server-1+rate-limited-stream-dev (= ${binary:Version}),
  librust-proxmox-rest-server-1.0+rate-limited-stream-dev (= ${binary:Version}),
diff --git a/proxmox-rest-server/src/connection.rs b/proxmox-rest-server/src/connection.rs
index 9511b7cb..6ffaac73 100644
--- a/proxmox-rest-server/src/connection.rs
+++ b/proxmox-rest-server/src/connection.rs
@@ -24,7 +24,9 @@ use tokio_openssl::SslStream;
 use tokio_stream::wrappers::ReceiverStream;
 
 #[cfg(feature = "rate-limited-stream")]
-use proxmox_http::{RateLimitedStream, ShareableRateLimit};
+use proxmox_http::RateLimitedStream;
+#[cfg(feature = "rate-limited-stream")]
+use proxmox_rate_limiter::ShareableRateLimit;
 
 #[cfg(feature = "rate-limited-stream")]
 pub type SharedRateLimit = Arc<dyn ShareableRateLimit>;
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-11-12 11:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-12 11:53 [pbs-devel] [PATCH proxmox{, -backup} v3 0/9] shared rate limiter for s3 client instances Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox v3 1/5] rate-limiter: add crate for traffic rate limiter implementations Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox v3 2/5] rate-limiter: avoid division by zero in traffic updater Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox v3 3/5] http: drop factored out rate limiter implementation Christian Ebner
2025-11-12 11:53 ` Christian Ebner [this message]
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox v3 5/5] s3-client: add shared rate limiter via https connector Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox-backup v3 1/4] traffic control: use factored out shared rate limiter Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox-backup v3 2/4] api: config: update s3 endpoint rate limits in config Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox-backup v3 3/4] datastore: s3: set rate limiter options for s3 client Christian Ebner
2025-11-12 11:53 ` [pbs-devel] [PATCH proxmox-backup v3 4/4] ui: expose rate and burst limits for s3 endpoints Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20251112115353.277514-5-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal