From: Hannes Laimer <h.laimer@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox{, -backup} v2 0/5] unmount datastores after sync job
Date: Wed, 29 Oct 2025 17:00:58 +0100	[thread overview]
Message-ID: <20251029160103.241780-1-h.laimer@proxmox.com> (raw)
Adds the option to automatically unmount a datastore after a sync job
finishes.
The idea is that, in combination with run-on-mount, it is possible to
have datastores sync to external drives without the need to open the web
ui or terminal. This came up a handful of times in support and a recent
thread on the forum. Basically, also non-tech people could be tasked
with plugging and unplugging different drives regularly and mounting,
sync and unmounting would be done automatically.
Currently if any of the triggered jobs have the 'unmount-on-done' flag
set the datastore will be unmounted right after the last of the
triggered jobs finishes.
This seemed pretty straight forward and should be good in most use-cases
I came up with. Also, I did consider having 'unmount-on-done' also for
normally(schedule/manual) started jobs, I guess there could be some
situations where that might useful. But, as I mentioned on the commit
itself, we'd probably have to go through the command socket since sync jobs run
on the proxy. And I did not think it adds that much, also not sure if
we'd even want that.
Tested-by: Robert Obkircher <r.obkircher@proxmox.com>
v2, thanks @Robert and @Shannon
 - include short docs section
 - fix typo
 - fix test
 - use `|=` (instead of `= ... || ...`)
proxmox:
Hannes Laimer (1):
  pbs-api-types: add 'unmount-on-done' field to sync job config
 pbs-api-types/src/jobs.rs | 8 ++++++++
 1 file changed, 8 insertions(+)
proxmox-backup:
Hannes Laimer (4):
  api: syncjob: correctly update/delete 'unmount-on-done' field
  api: datastore: unmount datastore after sync if configured
  ui: add 'unmount-on-done' field to SyncJobEdit window
  docs: add section about `unmount-on-done`
 docs/managing-remotes.rst   |  4 ++++
 src/api2/admin/datastore.rs | 21 +++++++++++++++++++--
 src/api2/config/sync.rs     |  9 +++++++++
 www/window/SyncJobEdit.js   | 23 +++++++++++++++++++++++
 4 files changed, 55 insertions(+), 2 deletions(-)
Summary over all repositories:
  5 files changed, 63 insertions(+), 2 deletions(-)
-- 
Generated by git-murpp 0.8.1
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next             reply	other threads:[~2025-10-29 16:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-29 16:00 Hannes Laimer [this message]
2025-10-29 16:00 ` [pbs-devel] [PATCH proxmox v2 1/1] pbs-api-types: add 'unmount-on-done' field to sync job config Hannes Laimer
2025-10-29 16:01 ` [pbs-devel] [PATCH proxmox-backup v2 1/4] api: syncjob: correctly update/delete 'unmount-on-done' field Hannes Laimer
2025-10-29 16:01 ` [pbs-devel] [PATCH proxmox-backup v2 2/4] api: datastore: unmount datastore after sync if configured Hannes Laimer
2025-10-29 16:01 ` [pbs-devel] [PATCH proxmox-backup v2 3/4] ui: add 'unmount-on-done' field to SyncJobEdit window Hannes Laimer
2025-10-29 16:01 ` [pbs-devel] [PATCH proxmox-backup v2 4/4] docs: add section about `unmount-on-done` Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20251029160103.241780-1-h.laimer@proxmox.com \
    --to=h.laimer@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox