[pbs-devel] [PATCH proxmox-backup v2] sync job: pull: avoid blocking future during thread pool completion

[pbs-devel] [PATCH proxmox-backup v2] sync job: pull: avoid blocking future during thread pool completion

[Christian Ebner]

Chunk insertion during a pull sync job is performed via a thread pool
to increase performance. The caller waits for all threads to be
completed at the end, relying on the respective associated threads to
return from `std::thread::JoinHandle::join`.

Insertion into the chunk store can however take time, especially
for chunks being uploaded to the object store for datastores with
S3 backend.

To avoid blocking the async runtime, spawn a dedicated task to await
the thread pool completion.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 1:
- fix incorrect error handling

 src/server/pull.rs | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/server/pull.rs b/src/server/pull.rs
index 08e6e6b64..817b57ac5 100644
--- a/src/server/pull.rs
+++ b/src/server/pull.rs
@@ -232,7 +232,7 @@ async fn pull_index_chunks<I: IndexFile>(
 
     drop(verify_and_write_channel);
 
-    verify_pool.complete()?;
+    tokio::task::spawn_blocking(|| verify_pool.complete()).await??;
 
     let elapsed = start_time.elapsed()?;
 
-- 
2.47.3



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox-backup v2] sync job: pull: avoid blocking future during thread pool completion

[Fabian Grünbichler]

On Tue, 14 Oct 2025 13:54:29 +0200, Christian Ebner wrote:
> Chunk insertion during a pull sync job is performed via a thread pool
> to increase performance. The caller waits for all threads to be
> completed at the end, relying on the respective associated threads to
> return from `std::thread::JoinHandle::join`.
> 
> Insertion into the chunk store can however take time, especially
> for chunks being uploaded to the object store for datastores with
> S3 backend.
> 
> [...]

Applied, thanks!

[1/1] sync job: pull: avoid blocking future during thread pool completion
      commit: 80b69ffc718cd7cbfa9e7c771cb8058261ca2c31

Best regards,
-- 
Fabian Grünbichler <f.gruenbichler@proxmox.com>


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel