[pbs-devel] [PATCH proxmox v2 6/6] s3-client: use better fitting name for TCP idle time

[Christian Ebner <c.ebner@proxmox.com>]

Although called tcp_keepalive in the HttpsConnector, the parameter
sets the idle time before starting to send TCP keepalive requests [0].

Rename the constant to be better fitting, avoiding possible confusion
with tcp keepalive interval.

[0] https://git.proxmox.com/?p=proxmox.git;a=blob;f=proxmox-sys/src/linux/socket.rs;h=f1f108fb8c88c19cdd8850b17dc8191782d3d6ec;hb=HEAD#l13

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-s3-client/src/client.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index e3845111..96a5878d 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -35,7 +35,7 @@ use crate::response_reader::{
 pub const S3_HTTP_REQUEST_TIMEOUT: Duration = Duration::from_secs(30 * 60);
 
 const S3_HTTP_CONNECT_TIMEOUT: Duration = Duration::from_secs(10);
-const S3_TCP_KEEPALIVE_TIME: u32 = 120;
+const S3_TCP_KEEPIDLE_TIME: u32 = 120;
 const MAX_S3_UPLOAD_RETRY: usize = 3;
 // Assumed minimum upload rate of 1 KiB/s for dynamic put object request timeout calculation.
 const S3_MIN_ASSUMED_UPLOAD_RATE: u64 = 1024;
@@ -154,7 +154,7 @@ impl S3Client {
         let https_connector = HttpsConnector::with_connector(
             http_connector,
             ssl_connector_builder.build(),
-            S3_TCP_KEEPALIVE_TIME,
+            S3_TCP_KEEPIDLE_TIME,
         );
         let client = Client::builder(TokioExecutor::new()).build::<_, Body>(https_connector);
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel