public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v2 3/6] s3-client: fix unintended match statement being an expression
Date: Mon, 25 Aug 2025 15:10:03 +0200	[thread overview]
Message-ID: <20250825131007.626777-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250825131007.626777-1-c.ebner@proxmox.com>

The match in question is not intendended to be an expression, so drop
the block trailing semicolon, adding it to the bail instead.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-s3-client/src/client.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index 4301f1af..ab2582bf 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -684,7 +684,7 @@ impl S3Client {
                 Ok(PutObjectResponse::PreconditionFailed) => return Ok(true),
                 Ok(PutObjectResponse::NeedsRetry) => {
                     if retry >= MAX_S3_UPLOAD_RETRY - 1 {
-                        bail!("concurrent operation, upload failed")
+                        bail!("concurrent operation, upload failed");
                     }
                 }
                 Err(err) => {
@@ -692,7 +692,7 @@ impl S3Client {
                         return Err(err.context("upload failed"));
                     }
                 }
-            };
+            }
         }
         Ok(false)
     }
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-08-25 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 13:10 [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] fix #6665: never mark chunks as bad on s3 client fetch error Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 1/6] proxmox-http: add method to share full body as contiguous bytes Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 2/6] s3-client: drop non-ambiguous mention of chunks in error message Christian Ebner
2025-08-25 13:10 ` Christian Ebner [this message]
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 4/6] s3-client: bump s3 request timeout from 1 minute to 30 minutes Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 5/6] s3-client: add retry logic for transient client errors Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 6/6] s3-client: use better fitting name for TCP idle time Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox-backup v2 1/1] fix #6665: never rename chunks on s3 client fetch errors Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825131007.626777-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal