public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v2 1/6] proxmox-http: add method to share full body as contiguous bytes
Date: Mon, 25 Aug 2025 15:10:01 +0200	[thread overview]
Message-ID: <20250825131007.626777-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250825131007.626777-1-c.ebner@proxmox.com>

While already possible to get the body contents as bytes slice,
exposing it as `Bytes` object has the advantage to be able to
efficiently clone the body when a shared reference is not possible,
e.g. for request cloning.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-http/src/body.rs | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/proxmox-http/src/body.rs b/proxmox-http/src/body.rs
index 3eb17355..a1dade27 100644
--- a/proxmox-http/src/body.rs
+++ b/proxmox-http/src/body.rs
@@ -35,6 +35,14 @@ impl Body {
         }
     }
 
+    /// Returns the body contents as `Bytes` it is a "full" body, None otherwise.
+    pub fn bytes(&self) -> Option<Bytes> {
+        match self.inner {
+            InnerBody::Full(ref bytes) => Some(bytes.clone()),
+            InnerBody::Streaming(_) => None,
+        }
+    }
+
     pub fn wrap_stream<S>(stream: S) -> Body
     where
         S: futures::stream::TryStream + Send + 'static,
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  reply	other threads:[~2025-08-25 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-25 13:10 [pbs-devel] [PATCH proxmox{, -backup} v2 0/7] fix #6665: never mark chunks as bad on s3 client fetch error Christian Ebner
2025-08-25 13:10 ` Christian Ebner [this message]
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 2/6] s3-client: drop non-ambiguous mention of chunks in error message Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 3/6] s3-client: fix unintended match statement being an expression Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 4/6] s3-client: bump s3 request timeout from 1 minute to 30 minutes Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 5/6] s3-client: add retry logic for transient client errors Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox v2 6/6] s3-client: use better fitting name for TCP idle time Christian Ebner
2025-08-25 13:10 ` [pbs-devel] [PATCH proxmox-backup v2 1/1] fix #6665: never rename chunks on s3 client fetch errors Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250825131007.626777-2-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal