[pbs-devel] [PATCH proxmox] s3-client: drop to restrictive minimum length check in region schema

[pbs-devel] [PATCH proxmox] s3-client: drop to restrictive minimum length check in region schema

[Christian Ebner]

As reported in the community forum, the current minimum length of 3
characters for regions to be set in the s3 endpoint configuration is
to restrictive, as at least OVH also allows 2 character regions [0].

The region regex pattern already limits the minimum input anyways, so
simply drop the currently set minimum length check.

[0] https://help.ovhcloud.com/csm/en-public-cloud-storage-s3-location?id=kb_article_view&sysparm_article=KB0047384

Fixes: https://forum.proxmox.com/threads/170146/
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 proxmox-s3-client/src/api_types.rs | 1 -
 1 file changed, 1 deletion(-)

diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs
index c68d85ef..115b1d2d 100644
--- a/proxmox-s3-client/src/api_types.rs
+++ b/proxmox-s3-client/src/api_types.rs
@@ -47,7 +47,6 @@ pub const S3_ENDPOINT_SCHEMA: Schema = StringSchema::new("Endpoint to access S3
 /// Region to access S3 object store.
 pub const S3_REGION_SCHEMA: Schema = StringSchema::new("Region to access S3 object store.")
     .format(&S3_REGION_FORMAT)
-    .min_length(3)
     .max_length(32)
     .schema();
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel

[pbs-devel] applied: [PATCH proxmox] s3-client: drop to restrictive minimum length check in region schema

[Wolfgang Bumiller]

applied, thanks

On Fri, Aug 22, 2025 at 05:12:39PM +0200, Christian Ebner wrote:
> As reported in the community forum, the current minimum length of 3
> characters for regions to be set in the s3 endpoint configuration is
> to restrictive, as at least OVH also allows 2 character regions [0].
> 
> The region regex pattern already limits the minimum input anyways, so
> simply drop the currently set minimum length check.
> 
> [0] https://help.ovhcloud.com/csm/en-public-cloud-storage-s3-location?id=kb_article_view&sysparm_article=KB0047384
> 
> Fixes: https://forum.proxmox.com/threads/170146/
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
>  proxmox-s3-client/src/api_types.rs | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/proxmox-s3-client/src/api_types.rs b/proxmox-s3-client/src/api_types.rs
> index c68d85ef..115b1d2d 100644
> --- a/proxmox-s3-client/src/api_types.rs
> +++ b/proxmox-s3-client/src/api_types.rs
> @@ -47,7 +47,6 @@ pub const S3_ENDPOINT_SCHEMA: Schema = StringSchema::new("Endpoint to access S3
>  /// Region to access S3 object store.
>  pub const S3_REGION_SCHEMA: Schema = StringSchema::new("Region to access S3 object store.")
>      .format(&S3_REGION_FORMAT)
> -    .min_length(3)
>      .max_length(32)
>      .schema();
>  
> -- 
> 2.47.2


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel