public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Maximiliano Sandoval <m.sandoval@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two
Date: Wed, 13 Aug 2025 14:43:42 +0200	[thread overview]
Message-ID: <20250813124347.452585-1-m.sandoval@proxmox.com> (raw)

In a support case we found a system with 40:00 as a schedule in a backup job. It
is possible to entire this calendar event on the web UI.

As per systemd-analize:

```
$ systemd-analyze calendar 40:00
Failed to parse calendar specification '40:00': Invalid argument
```

After this series the Proxmox VE web UI won't allow it anymore with an error:

```
Parameter verification failed. (400)

schedule: invalid format - invalid calendar event '40:00' - unable to parse calendar event at ':00' - Nom(Eof) 
```

Differences from v1:
 - Add cover letter
 - Reference bugzilla entry #6161
 - Add test case for 24:00 as per #6161

Maximiliano Sandoval (3):
  time: Add traits to DateTimeValue and TimeSpec
  fix #6161: time: Split parse_time_spec parser into two
  time: Add more calendat event tests

 proxmox-time/src/calendar_event.rs  | 109 ++++++++++++++++++++++++++--
 proxmox-time/src/date_time_value.rs |   2 +-
 2 files changed, 103 insertions(+), 8 deletions(-)

-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-08-13 12:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-13 12:43 Maximiliano Sandoval [this message]
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 1/3] time: Add traits to DateTimeValue and TimeSpec Maximiliano Sandoval
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 2/3] fix #6161: time: Split parse_time_spec parser into two Maximiliano Sandoval
2025-08-13 12:43 ` [pbs-devel] [PATCH proxmox v2 3/3] time: Add more calendat event tests Maximiliano Sandoval
2025-08-26 21:58 ` [pbs-devel] [PATCH proxmox v2 0/3] fix #6161: time: Split parse_time_spec parser into two Thomas Lamprecht
2025-08-27  8:40   ` Maximiliano Sandoval
2025-08-27  9:02     ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250813124347.452585-1-m.sandoval@proxmox.com \
    --to=m.sandoval@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal