From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 0/2] fix non-optional date header for S3 api response parsing
Date: Fri, 8 Aug 2025 13:41:15 +0200 [thread overview]
Message-ID: <20250808114117.393536-1-c.ebner@proxmox.com> (raw)
Fixes an implementation oversight with possibly missing http date
headers in the S3 API response parsing. The header is included in
the response by almost all providers, but it is documented as being
optional.
Also, includes regression tests for the http date header parsing.
Since the now optional date header in responses is currently not used
by any code path (it was only ever considered for time drift detection
between host and s3 provider), no further adaptions are required.
This will avoid issues as reported in:
https://forum.proxmox.com/threads/169395/
Christian Ebner (2):
s3-client: fix non-optional date header for api response parsing
s3-client: add regression tests for http date header parsing
proxmox-s3-client/src/response_reader.rs | 57 +++++++++++++++++++-----
proxmox-s3-client/src/timestamps.rs | 2 +-
2 files changed, 48 insertions(+), 11 deletions(-)
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next reply other threads:[~2025-08-08 11:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-08 11:41 Christian Ebner [this message]
2025-08-08 11:41 ` [pbs-devel] [PATCH proxmox 1/2] s3-client: fix non-optional date header for " Christian Ebner
2025-08-08 11:41 ` [pbs-devel] [PATCH proxmox 2/2] s3-client: add regression tests for http date header parsing Christian Ebner
2025-08-11 12:30 ` [pbs-devel] applied-series: [PATCH proxmox 0/2] fix non-optional date header for S3 api response parsing Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250808114117.393536-1-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox