From: Shannon Sterz <s.sterz@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/2] ui: opt open id authentication flows into the new http only flow
Date: Thu, 7 Aug 2025 12:49:12 +0200 [thread overview]
Message-ID: <20250807104909.198914-6-s.sterz@proxmox.com> (raw)
In-Reply-To: <20250807104909.198914-2-s.sterz@proxmox.com>
otherwise the cookie would not be properly set, leading to users
potentially getting logged out instantly again.
Analyzed-by: Mira Limbeck <m.limbeck@proxmox.com>
Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
www/LoginView.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/LoginView.js b/www/LoginView.js
index cf6c2cf7..08786080 100644
--- a/www/LoginView.js
+++ b/www/LoginView.js
@@ -197,6 +197,7 @@ Ext.define('PBS.LoginView', {
state: auth.state,
code: auth.code,
'redirect-url': redirectURL,
+ 'http-only': true,
},
method: 'POST',
failure: function (response) {
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-07 10:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-07 10:49 [pbs-devel] [PATCH proxmox-backup 0/2] add support for HttpOnly cookies for OpenID authentication flow Shannon Sterz
2025-08-07 10:49 ` [pbs-devel] [PATCH proxmox-backup 1/2] api: openid: allow users of openid to opt into the HttpOnly cookies Shannon Sterz
2025-08-07 11:46 ` Mira Limbeck
2025-08-07 11:51 ` Shannon Sterz
2025-08-07 10:49 ` Shannon Sterz [this message]
2025-08-07 12:05 ` [pbs-devel] Superseded: [PATCH proxmox-backup 0/2] add support for HttpOnly cookies for OpenID authentication flow Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250807104909.198914-6-s.sterz@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox