From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v4 2/2] ui: s3 endpoint: add provider specific quirk selector
Date: Tue, 5 Aug 2025 12:51:20 +0200 [thread overview]
Message-ID: <20250805105120.623089-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250805105120.623089-1-c.ebner@proxmox.com>
Add an advanced column with a provider specific quirk selector, which
allows to set the s3 endpoint accordingly and use the provider
specific implementation detail in the s3 client.
Clear the value if it is set to the default one, being no quirks.
For now only the one If-None-Match http header quirk is available, but
this can be extended to a multi selection list if required.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
changes since version 3:
- use provider quirks directly instead of provider list
www/window/S3ClientEdit.js | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/www/window/S3ClientEdit.js b/www/window/S3ClientEdit.js
index f0a5efba8..5128f6a54 100644
--- a/www/window/S3ClientEdit.js
+++ b/www/window/S3ClientEdit.js
@@ -119,6 +119,23 @@ Ext.define('PBS.window.S3ClientEdit', {
},
},
],
+
+ advancedColumn1: [
+ {
+ xtype: 'proxmoxKVComboBox',
+ name: 'provider-quirks',
+ fieldLabel: gettext('Provider specific quirks'),
+ value: '__default__',
+ defaultValue: '__default__',
+ comboItems: [
+ ['__default__', 'None (default)'],
+ ['skip-if-none-match-header', 'Skip If-None-Match header'],
+ ],
+ cbind: {
+ deleteEmpty: '{!isCreate}',
+ },
+ },
+ ],
},
getValues: function () {
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-05 10:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-05 10:51 [pbs-devel] [PATCH proxmox{, -backup} v4 0/3] s3: extend endpoint config and client options by provider-quirks Christian Ebner
2025-08-05 10:51 ` [pbs-devel] [PATCH proxmox v4 1/1] s3 client: extend client config and options by optional provider quirks Christian Ebner
2025-08-05 15:36 ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-05 10:51 ` [pbs-devel] [PATCH proxmox-backup v4 1/2] api: s3 config: allow to update or delete endpoint quirks Christian Ebner
2025-08-05 15:40 ` [pbs-devel] applied: " Thomas Lamprecht
2025-08-05 10:51 ` Christian Ebner [this message]
2025-08-05 15:40 ` [pbs-devel] applied: [PATCH proxmox-backup v4 2/2] ui: s3 endpoint: add provider specific quirk selector Thomas Lamprecht
2025-08-05 16:42 ` Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250805105120.623089-4-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox