From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup v3 1/2] api: s3 config: allow to update or delete endpoint quirks
Date: Mon, 4 Aug 2025 08:53:30 +0200 [thread overview]
Message-ID: <20250804065331.45272-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250804065331.45272-1-c.ebner@proxmox.com>
Allows to update the configured quirk value, to be used by the s3
endpoint config edit window as well as the cli.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
---
changes since version 2:
- no changes
src/api2/config/s3.rs | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/src/api2/config/s3.rs b/src/api2/config/s3.rs
index 047bf1fb1..803a1f792 100644
--- a/src/api2/config/s3.rs
+++ b/src/api2/config/s3.rs
@@ -125,6 +125,8 @@ pub enum DeletableProperty {
Fingerprint,
/// Delete the path-style property.
PathStyle,
+ /// Delete the provider quirks property.
+ ProviderQuirks,
}
#[api(
@@ -197,6 +199,9 @@ pub fn update_s3_client_config(
DeletableProperty::PathStyle => {
data.config.path_style = None;
}
+ DeletableProperty::ProviderQuirks => {
+ data.config.provider_quirks = None;
+ }
}
}
}
@@ -219,6 +224,9 @@ pub fn update_s3_client_config(
if let Some(path_style) = update.path_style {
data.config.path_style = Some(path_style);
}
+ if let Some(provider_quirks) = update.provider_quirks {
+ data.config.provider_quirks = Some(provider_quirks);
+ }
if let Some(secret_key) = secret_key {
data.secret_key = secret_key;
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-08-04 6:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 6:53 [pbs-devel] [PATCH proxmox{, -backup} v3 0/4] s3: extend config by provider-quirks and client options by feature list Christian Ebner
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox v3 1/2] s3 client: api types: extend client config by optional provider quirks Christian Ebner
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox v3 2/2] s3 client: extend client options by feature list Christian Ebner
2025-08-04 6:53 ` Christian Ebner [this message]
2025-08-04 6:53 ` [pbs-devel] [PATCH proxmox-backup v3 2/2] ui: s3 endpoint: add provider specific quirk selector Christian Ebner
2025-08-04 20:17 ` [pbs-devel] [PATCH proxmox{, -backup} v3 0/4] s3: extend config by provider-quirks and client options by feature list Thomas Lamprecht
2025-08-05 5:58 ` Christian Ebner
2025-08-05 6:15 ` Thomas Lamprecht
2025-08-05 10:52 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250804065331.45272-4-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox