public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox-backup 2/4] datastore: introduce helper to get store's backend type
Date: Thu, 31 Jul 2025 09:39:48 +0200	[thread overview]
Message-ID: <20250731073950.73526-4-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250731073950.73526-1-c.ebner@proxmox.com>

In contrast to the pre-existing backend() helper, this newly
introduced backend_type() helper allows to determine a datastores
backend without already instantiating the s3 client in case the
backend is s3.

This will allow to fetch the backend type for the datastore's status
api without having to re-lookup the config.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
 pbs-datastore/src/datastore.rs | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index e8be576f7..5eb4b944b 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -234,7 +234,7 @@ impl DataStore {
 
     /// Get the backend for this datastore based on it's configuration
     pub fn backend(&self) -> Result<DatastoreBackend, Error> {
-        let backend_type = match self.inner.backend_config.ty.unwrap_or_default() {
+        let backend = match self.backend_type() {
             DatastoreBackendType::Filesystem => DatastoreBackend::Filesystem,
             DatastoreBackendType::S3 => {
                 let s3_client_id = self
@@ -264,7 +264,11 @@ impl DataStore {
             }
         };
 
-        Ok(backend_type)
+        Ok(backend)
+    }
+
+    pub fn backend_type(&self) -> DatastoreBackendType {
+        self.inner.backend_config.ty.unwrap_or_default()
     }
 
     pub fn cache(&self) -> Option<&LocalDatastoreLruCache> {
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


  parent reply	other threads:[~2025-07-31  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  7:39 [pbs-devel] [RFC proxmox{, -backup} 0/5] switch local storage usage titles based on datastore backend Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add backend type to datastore's status items Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 1/4] api: status: expose backend type in datastore status list item Christian Ebner
2025-07-31  7:39 ` Christian Ebner [this message]
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: datastore: expose the datastore backend type in the status output Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: Set datastore usage related titles based on backend Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731073950.73526-4-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal