From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add backend type to datastore's status items
Date: Thu, 31 Jul 2025 09:39:46 +0200 [thread overview]
Message-ID: <20250731073950.73526-2-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250731073950.73526-1-c.ebner@proxmox.com>
Add the backend type to both, the datastore status and the datastore
status list item. This allows to interpret the provided data based
on the backend without the need to determine the backend type by
additional api calls.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
pbs-api-types/src/datastore.rs | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)
diff --git a/pbs-api-types/src/datastore.rs b/pbs-api-types/src/datastore.rs
index ee94ccad..e684c8f2 100644
--- a/pbs-api-types/src/datastore.rs
+++ b/pbs-api-types/src/datastore.rs
@@ -1628,6 +1628,9 @@ pub struct GarbageCollectionJobStatus {
type: Counts,
optional: true,
},
+ "backend-type": {
+ type: DatastoreBackendType,
+ },
},
)]
#[derive(Serialize, Deserialize)]
@@ -1646,6 +1649,9 @@ pub struct DataStoreStatus {
/// Group/Snapshot counts
#[serde(skip_serializing_if = "Option::is_none")]
pub counts: Option<Counts>,
+ /// Datastore backend type
+ #[serde(default)]
+ pub backend_type: DatastoreBackendType,
}
#[api(
@@ -1664,6 +1670,9 @@ pub struct DataStoreStatus {
description: "The usage of a time in the past. Either null or between 0.0 and 1.0.",
}
},
+ "backend-type": {
+ type: DatastoreBackendType,
+ },
},
)]
#[derive(Serialize, Deserialize, Clone, PartialEq)]
@@ -1703,10 +1712,18 @@ pub struct DataStoreStatusListItem {
/// Status of last GC
#[serde(skip_serializing_if = "Option::is_none")]
pub gc_status: Option<GarbageCollectionStatus>,
+ /// Datastore backend type
+ #[serde(default)]
+ pub backend_type: DatastoreBackendType,
}
impl DataStoreStatusListItem {
- pub fn empty(store: &str, err: Option<String>, mount_status: DataStoreMountStatus) -> Self {
+ pub fn empty(
+ store: &str,
+ err: Option<String>,
+ mount_status: DataStoreMountStatus,
+ backend_type: DatastoreBackendType,
+ ) -> Self {
DataStoreStatusListItem {
store: store.to_owned(),
total: None,
@@ -1719,6 +1736,7 @@ impl DataStoreStatusListItem {
estimated_full_date: None,
error: err,
gc_status: None,
+ backend_type,
}
}
}
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-31 7:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-31 7:39 [pbs-devel] [RFC proxmox{, -backup} 0/5] switch local storage usage titles based on datastore backend Christian Ebner
2025-07-31 7:39 ` Christian Ebner [this message]
2025-07-31 7:39 ` [pbs-devel] [PATCH proxmox-backup 1/4] api: status: expose backend type in datastore status list item Christian Ebner
2025-07-31 7:39 ` [pbs-devel] [PATCH proxmox-backup 2/4] datastore: introduce helper to get store's backend type Christian Ebner
2025-07-31 7:39 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: datastore: expose the datastore backend type in the status output Christian Ebner
2025-07-31 7:39 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: Set datastore usage related titles based on backend Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250731073950.73526-2-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox