public inbox for pbs-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [RFC proxmox{, -backup} 0/5] switch local storage usage titles based on datastore backend
Date: Thu, 31 Jul 2025 09:39:45 +0200	[thread overview]
Message-ID: <20250731073950.73526-1-c.ebner@proxmox.com> (raw)

This patches try to more clearly show to the user that the statistic shown
in the datastore summary and overview only show the local cache usage.

To achieve this, the first patches include the datastore backend type in both,
responses for the `datastore-usage` as well as `status` api endpoints, in order
to be able to adapt the shown information conditionally.

Based on the backend, the title for the disk usage and rrd chart are adapted,
the estimated full values are also not shown in case of local caches.

This is intended more as a stop gap until a more sophisticated dashboard and
statistics are implemented for S3 backends as tracked in [0].

Sending this as RFC as I am unsure if:
- it is acceptable to include the backend type in these api responses, as they
  are intended for dynamic status changes?
- there is a better/alternative way to get the backend type?
- it might make sense to simply not return usage statistics for the cache (e.g.
  returning 0 values only) and keep this api endpoints free to be reused for the
  S3 dashboard?

[0] https://bugzilla.proxmox.com/show_bug.cgi?id=6563

proxmox:

Christian Ebner (1):
  pbs-api-types: add backend type to datastore's status items

 pbs-api-types/src/datastore.rs | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)


proxmox-backup:

Christian Ebner (4):
  api: status: expose backend type in datastore status list item
  datastore: introduce helper to get store's backend type
  api: datastore: expose the datastore backend type in the status output
  ui: Set datastore usage related titles based on backend

 pbs-datastore/src/datastore.rs        |  8 ++++++--
 src/api2/admin/datastore.rs           |  4 ++++
 src/api2/status/mod.rs                | 18 +++++++++++++++---
 www/datastore/DataStoreListSummary.js | 10 ++++++++--
 www/datastore/Summary.js              | 12 ++++++++++++
 5 files changed, 45 insertions(+), 7 deletions(-)


Summary over all repositories:
  6 files changed, 64 insertions(+), 8 deletions(-)

-- 
Generated by git-murpp 0.8.1


_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel


             reply	other threads:[~2025-07-31  7:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  7:39 Christian Ebner [this message]
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox 1/1] pbs-api-types: add backend type to datastore's status items Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 1/4] api: status: expose backend type in datastore status list item Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 2/4] datastore: introduce helper to get store's backend type Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 3/4] api: datastore: expose the datastore backend type in the status output Christian Ebner
2025-07-31  7:39 ` [pbs-devel] [PATCH proxmox-backup 4/4] ui: Set datastore usage related titles based on backend Christian Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250731073950.73526-1-c.ebner@proxmox.com \
    --to=c.ebner@proxmox.com \
    --cc=pbs-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal