[pbs-devel] [PATCH proxmox-backup v2 1/8] tree wide: fix useless borrow warnings

[Christian Ebner <c.ebner@proxmox.com>]

Fix the useless borrows reported by `cargo clippy`.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
---
changes since version 1:
 - no changes

 pbs-config/src/datastore.rs        | 2 +-
 pbs-datastore/src/datastore.rs     | 6 +++---
 src/api2/config/tape_backup_job.rs | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/pbs-config/src/datastore.rs b/pbs-config/src/datastore.rs
index 5a5553dbc..4aecc0d3c 100644
--- a/pbs-config/src/datastore.rs
+++ b/pbs-config/src/datastore.rs
@@ -117,7 +117,7 @@ pub fn complete_calendar_event(_arg: &str, _param: &HashMap<String, String>) ->
 /// Returns the datastore backend type from it's name
 pub fn datastore_backend_type(store: &str) -> Result<pbs_api_types::DatastoreBackendType, Error> {
     let (config, _) = config()?;
-    let store_config: DataStoreConfig = config.lookup("datastore", &store)?;
+    let store_config: DataStoreConfig = config.lookup("datastore", store)?;
 
     let backend_config: pbs_api_types::DatastoreBackendConfig = serde_json::from_value(
         pbs_api_types::DatastoreBackendConfig::API_SCHEMA
diff --git a/pbs-datastore/src/datastore.rs b/pbs-datastore/src/datastore.rs
index e8be576f7..e3c0589a4 100644
--- a/pbs-datastore/src/datastore.rs
+++ b/pbs-datastore/src/datastore.rs
@@ -1780,7 +1780,7 @@ impl DataStore {
         delete_list: &mut Vec<S3ObjectKey>,
         gc_status: &mut GarbageCollectionStatus,
     ) -> Result<bool, Error> {
-        let (chunk_path, digest) = match self.chunk_path_from_object_key(&object_key) {
+        let (chunk_path, digest) = match self.chunk_path_from_object_key(object_key) {
             Some(path) => path,
             None => return Ok(false),
         };
@@ -2218,7 +2218,7 @@ impl DataStore {
                 .await?
                 .context("failed to set maintenance mode")?;
 
-                let tmp_base = proxmox_sys::fs::make_tmp_dir(&self.base_path(), None)
+                let tmp_base = proxmox_sys::fs::make_tmp_dir(self.base_path(), None)
                     .context("failed to create temporary content folder in {store_base}")?;
 
                 if let Err(err) = async {
@@ -2377,7 +2377,7 @@ impl DataStore {
             .with_context(|| format!("failed to refresh {:?}", self.base_path()))?;
         }
 
-        std::fs::remove_dir_all(&tmp_base)
+        std::fs::remove_dir_all(tmp_base)
             .with_context(|| format!("failed to cleanup temporary content in {tmp_base:?}"))?;
 
         Ok(())
diff --git a/src/api2/config/tape_backup_job.rs b/src/api2/config/tape_backup_job.rs
index 786acde06..38dbe9747 100644
--- a/src/api2/config/tape_backup_job.rs
+++ b/src/api2/config/tape_backup_job.rs
@@ -185,7 +185,7 @@ pub fn update_tape_backup_job(
     digest: Option<String>,
 ) -> Result<(), Error> {
     if let Some(store) = &update.setup.store {
-        assert_datastore_type(&store)?;
+        assert_datastore_type(store)?;
     }
     let _lock = pbs_config::tape_job::lock()?;
 
-- 
2.47.2



_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel