From: Stefan Hanreich <s.hanreich@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 3/3] network-api: add rename_interfaces method
Date: Tue, 29 Jul 2025 18:56:49 +0200 [thread overview]
Message-ID: <20250729165655.681368-5-s.hanreich@proxmox.com> (raw)
In-Reply-To: <20250729165655.681368-1-s.hanreich@proxmox.com>
Used for batch renaming interfaces in the /e/n/i configuration file by
the proxmox-network-interface-pinning tool.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
---
proxmox-network-api/src/config/mod.rs | 68 +++++++++++++++++++++++++++
1 file changed, 68 insertions(+)
diff --git a/proxmox-network-api/src/config/mod.rs b/proxmox-network-api/src/config/mod.rs
index e8cb81d1..3b2ffdc2 100644
--- a/proxmox-network-api/src/config/mod.rs
+++ b/proxmox-network-api/src/config/mod.rs
@@ -267,6 +267,74 @@ impl NetworkConfig {
Ok(interface)
}
+ pub fn rename_interfaces(&mut self, mapping: &HashMap<String, String>) -> Result<(), Error> {
+ for (old_name, new_name) in mapping.iter() {
+ self.interfaces
+ .remove(old_name)
+ .map(|interface| self.interfaces.insert(new_name.to_string(), interface));
+
+ if let Some(idx) = self
+ .order
+ .iter()
+ .position(|elem| matches!(elem, NetworkOrderEntry::Iface(name) if name == new_name))
+ {
+ self.order[idx] = NetworkOrderEntry::Iface(new_name.to_string());
+ }
+ }
+
+ for interface in self.interfaces.values_mut() {
+ if let Some(new_name) = mapping.get(&interface.name) {
+ interface.name = new_name.to_string();
+ }
+
+ if let Some(bridge_ports) = interface.bridge_ports.take() {
+ interface.bridge_ports = Some(
+ bridge_ports
+ .into_iter()
+ .map(|interface| {
+ mapping
+ .get(&interface)
+ .map(String::from)
+ .unwrap_or(interface)
+ })
+ .collect(),
+ )
+ }
+
+ if let Some(vlan_raw_device) = interface.vlan_raw_device.take() {
+ if let Some(new_name) = mapping.get(&vlan_raw_device) {
+ interface.vlan_raw_device = Some(new_name.to_string());
+ } else {
+ interface.vlan_raw_device = Some(vlan_raw_device);
+ }
+ }
+
+ if let Some(slaves) = interface.slaves.take() {
+ interface.slaves = Some(
+ slaves
+ .into_iter()
+ .map(|interface| {
+ mapping
+ .get(&interface)
+ .map(String::from)
+ .unwrap_or(interface)
+ })
+ .collect(),
+ )
+ }
+
+ if let Some(bond_primary) = interface.bond_primary.take() {
+ if let Some(new_name) = mapping.get(&bond_primary) {
+ interface.bond_primary = Some(new_name.to_string());
+ } else {
+ interface.bond_primary = Some(bond_primary);
+ }
+ }
+ }
+
+ Ok(())
+ }
+
/// Check that there is no other gateway.
///
/// The gateway property is only allowed on passed 'iface'. This should be
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-29 16:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-29 16:56 [pbs-devel] [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} 0/8] proxmox-network-interface-pinning Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-ve-rs 1/1] host: network: move to proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox 1/3] pbs-api-types: use proxmox-network-api types Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox 2/3] proxmox-network-api: use ip link for querying interface information Stefan Hanreich
2025-07-29 16:56 ` Stefan Hanreich [this message]
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-backup 1/2] config: network: move to proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-backup 2/2] metric_collection: use ip link for determining the type of interfaces Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-firewall 1/1] firewall: config: use proxmox-network-api Stefan Hanreich
2025-07-29 16:56 ` [pbs-devel] [PATCH proxmox-network-interface-pinning 1/1] initial commit Stefan Hanreich
2025-07-30 13:07 ` Thomas Lamprecht
2025-07-30 13:14 ` Stefan Hanreich
2025-07-30 13:24 ` Thomas Lamprecht
2025-07-30 13:30 ` Fabian Grünbichler
2025-07-30 13:35 ` Stefan Hanreich
2025-07-30 13:42 ` Thomas Lamprecht
2025-07-30 14:37 ` [pbs-devel] superseded: [PATCH proxmox{-ve-rs, , -backup, -firewall, -network-interface-pinning} 0/8] proxmox-network-interface-pinning Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250729165655.681368-5-s.hanreich@proxmox.com \
--to=s.hanreich@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox