From: Christian Ebner <c.ebner@proxmox.com>
To: pbs-devel@lists.proxmox.com
Subject: [pbs-devel] [PATCH proxmox 2/2] s3 client: skip setting `If-None-Match` header for Backblaze B2
Date: Mon, 28 Jul 2025 12:01:52 +0200 [thread overview]
Message-ID: <20250728100154.556438-3-c.ebner@proxmox.com> (raw)
In-Reply-To: <20250728100154.556438-1-c.ebner@proxmox.com>
Backblaze B2 does not allow to set the `If-None-Match` http header
for put requests, failing with an error instead of implementing or
ignoring it. Skip setting the header (and therefore re-uploading
the object) if the quirk configuration is set to backblaze.
Reported-by: https://forum.proxmox.com/threads/168834/post-786278
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
---
proxmox-s3-client/src/client.rs | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/proxmox-s3-client/src/client.rs b/proxmox-s3-client/src/client.rs
index bbe363da..bd7aff18 100644
--- a/proxmox-s3-client/src/client.rs
+++ b/proxmox-s3-client/src/client.rs
@@ -396,7 +396,12 @@ impl S3Client {
.header(header::CONTENT_TYPE, "binary/octet");
if !replace {
- request = request.header(header::IF_NONE_MATCH, "*");
+ // Backblaze B2 does not implement this and fails with error if the header is set,
+ // see https://forum.proxmox.com/threads/168834/post-786278
+ match self.options.quirks.as_deref() {
+ Some("backblaze") => (),
+ _ => request = request.header(header::IF_NONE_MATCH, "*"),
+ }
}
let request = request.body(object_data)?;
--
2.47.2
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
next prev parent reply other threads:[~2025-07-28 10:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-28 10:01 [pbs-devel] [PATCH proxmox{, -backup} 0/4] s3: extend config by quirks, implement backblaze B2 specific quirk Christian Ebner
2025-07-28 10:01 ` [pbs-devel] [PATCH proxmox 1/2] s3 client: api types: extend client config by optional quirks Christian Ebner
2025-07-28 10:01 ` Christian Ebner [this message]
2025-07-28 10:01 ` [pbs-devel] [PATCH proxmox-backup 1/2] api: s3 config: allow to update or delete endpoint quirks Christian Ebner
2025-07-28 10:01 ` [pbs-devel] [PATCH proxmox-backup 2/2] ui: s3 endpoint: add provider specific quirk selector Christian Ebner
2025-07-29 6:36 ` [pbs-devel] [PATCH proxmox{, -backup} 0/4] s3: extend config by quirks, implement backblaze B2 specific quirk Christian Ebner
2025-07-29 8:19 ` [pbs-devel] superseded: " Christian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250728100154.556438-3-c.ebner@proxmox.com \
--to=c.ebner@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox